✅ Add tests for ignored regions in test archiver. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: This will have to be run through chromatic, since it's a change to the way the capture system works. Refs CAP-1291.
skitterm
approved these changes
Nov 28, 2023
There is a .vscode folder in chromatic and chromatic-cli, so we probably will want one in the future for this repository. It was ignored in the previous commit.
tevanoff
reviewed
Nov 28, 2023
tevanoff
reviewed
Nov 28, 2023
This change was requested during code review.
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This will have to be run through chromatic, since it's a change to the way the capture system works.
Refs CAP-1291.
How to test
You will need to build the archive and then test using chromatic's build system, but be aware that the patch for CAP-1291 needs to be in place first.
Change Type
maintenancedocumentationpatchminormajor📦 Published PR as canary version:
0.0.43--canary.41.ff9a077.0✨ Test out this PR locally via:
npm install @chromaui/test-archiver@0.0.43--canary.41.ff9a077.0 # or yarn add @chromaui/test-archiver@0.0.43--canary.41.ff9a077.0