Cypress doesn't wait for idle timeout #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es are there when navigating to the page
…s member, since it's only used in one method
… it doesn't need access to other class variables
skitterm
changed the title
7 tasks
tevanoff
reviewed
Jan 9, 2024
| @@ -1,9 +1,6 @@ | |||
| import type { Page } from 'playwright'; | |||
There was a problem hiding this comment.
Nice! We just need to get that Playwright protocol out of here now!
tevanoff
reviewed
Jan 9, 2024
| // tack on the protocol so we can properly check if requests are cross-origin | ||
| this.allowedArchiveOrigins = (allowedDomains || []).map((domain) => `https://${domain}`); | ||
| } | ||
|
|
||
| async watch() { | ||
| this.client.on('Network.requestWillBeSent', this.requestWillBeSent.bind(this)); |
There was a problem hiding this comment.
Ah I see below that the handlers only logged 👍
There was a problem hiding this comment.
Yeah, these only logged, and in fact they didn't end up getting fired when I put in the logger.
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Cypress doesn't wait 10 seconds (the global timeout amount) to finish tests anymore.
Instead of using the
Watcher.idle()to know when Cypress archives can be complete, I'm not waiting at all. This is becausecy.visit()(the command to visit a page) already waits for all resources to be loaded before it completes.This also means users' Cypress tests aren't any slower when they add Chromatic since we're not waiting a minimum of
500msafter each test.Also changed
Watcher.idle()is pulled out and into the Playwright-specific code since 1) Cypress doesn't need it and 2) it doesn't need access to anyWatcherclass variablesWatchermethods that were either 1) unused (setResponse()) or 2) were only used for logging and weren't actually ever even hit (requestWillBeSent()andresponseReceived())How to test
Change Type
maintenancedocumentationpatchminormajor📦 Published PR as canary version:
0.0.55--canary.54.b107684.0✨ Test out this PR locally via:
npm install @chromaui/test-archiver@0.0.55--canary.54.b107684.0 # or yarn add @chromaui/test-archiver@0.0.55--canary.54.b107684.0