Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Simplified the user API as follows:
Before:
After:
The user still needs to import our client-side beforeEach/afterEach hooks in their support file:
The user will unfortunately also still have to pass
ELECTRON_EXTRA_LAUNCH_ARGS=--remote-debugging-port=x
in front of theircypress run
command still. Cypress doesn't allow for specifying a remote debugging port for Chrome, and electron doesn't pass the browser launch options (info like the CDP port), so we're stuck needing thisELECTRON_EXTRA_LAUNCH_ARGS
env variable set by the user if they use Electron (which is the default forcypress run
). Technically they don't need it if they are using Chrome/Chromium, but I think it's better to have all users add this then have a bunch of if-this-then-that's in our setup guide.Note
Cypress lifecycle events can only be registered once. Because our
installPlugin()
registers an event listener onbefore:browser:launch
event, if the user has such an event already, they will need to callinstallPlugin()
first, and then register theirbefore:browser:launch
event, as follows:How to test
cypress.config.ts
file to match the new APIyarn cypress run
yarn archive-storybook
Change Type
maintenance
documentation
patch
minor
major
📦 Published PR as canary version:
0.0.56--canary.55.8655fbb.1
✨ Test out this PR locally via:
npm install @chromaui/test-archiver@0.0.56--canary.55.8655fbb.1 # or yarn add @chromaui/test-archiver@0.0.56--canary.55.8655fbb.1