Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip over CDP errors, but record to an error log #7

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Aug 2, 2023

What Changed

It seems various client.send() calls fail in circumstances we don't fully understand (e.g https://github.com/chromaui/chromatic/actions/runs/5618208830/attempts/1, and various customer reported issues).

It may be OK to ignore these errors -- in this PR, we skip over but record them to an errors.log. If resources are missing that are needed, we can refer to this log to see at what point the resource archiving failed.

How to test

I'm not sure how to reproduce the problem, but running the canary against a real project to make sure it still works is a good idea.

Change Type

  • maintenance
  • documentation
  • patch
  • minor
  • major

@linear
Copy link

linear bot commented Aug 2, 2023

AP-3454 Error: cdpSession.send: Target closed at m.requestPaused

How is the user affected? And what is the expected behavior?

<Use plain english, think about what the user is trying to but cannot do.>

User's (including our own Chromatic E2E project) playwright tests will sporadically fail due to an error in the

requestPaused function

The error often looks like

cdpSession.send: Protocol error (Fetch.continueRequest): Invalid InterceptionId.

How many and/or what class of users does this impact?

<Examples are: All Github users, An estimated 30 Bitbucket users with expired tokens, etc …>

3 E2E beta users

Is there a workaround?

<If so, describe it.>

No

What are the steps for reproducing the issue?

<First, try to reproduce the issue. Be as precise as you can with the steps to help the developer and QA person save time. If you can't reproduce it, describe what you tried and add the Needs Repro label.>

TBD

Other information

@tmeasday tmeasday merged commit e84ad34 into main Aug 4, 2023
2 checks passed
@tmeasday tmeasday deleted the tom/ap-3454-error-cdpsessionsend-target-closed-at-mrequestpaused branch August 4, 2023 00:00
@tmeasday
Copy link
Member Author

tmeasday commented Aug 9, 2023

🚀 PR was released in v0.0.18 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants