Skip over CDP errors, but record to an error log #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
It seems various
client.send()
calls fail in circumstances we don't fully understand (e.g https://github.com/chromaui/chromatic/actions/runs/5618208830/attempts/1, and various customer reported issues).It may be OK to ignore these errors -- in this PR, we skip over but record them to an
errors.log
. If resources are missing that are needed, we can refer to this log to see at what point the resource archiving failed.How to test
I'm not sure how to reproduce the problem, but running the canary against a real project to make sure it still works is a good idea.
Change Type
maintenance
documentation
patch
minor
major