Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish version #12

Closed
domyen opened this issue Apr 11, 2018 · 13 comments
Closed

Spanish version #12

domyen opened this issue Apr 11, 2018 · 13 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@domyen
Copy link
Member

domyen commented Apr 11, 2018

This is the discussion for the Spanish version of Learn Storybook. Use this issue to divvy up translation, request feedback, etc. For more info about the translation project and to get involved checkout #3

Please target your PRs at branch language-spanish. 🙏

cc @icarlossz and @luchux

@domyen domyen added enhancement New feature or request help wanted Extra attention is needed labels Apr 11, 2018
@icarlossz
Copy link
Contributor

All right. 👨🏻‍💻

@luchux
Copy link
Contributor

luchux commented May 29, 2018

@icarlossz Querés que traduzca todos los capítulos que quedan, desde el último que aceptaste en el PR, hasta el final? Vos después podes hacer la revisión, los fixes, y aceptar el PR.

Así terminamos de una. Yo estoy bastante al pedo, idle, estos días y me gustaría ir cerrando esto.

Salutes bro.

@icarlossz
Copy link
Contributor

Ando igual ahora mismo yo, si querés sigamos como veníamos de uno a uno y cada uno le hace code review al otro. Contame si te parece.

@luchux
Copy link
Contributor

luchux commented May 30, 2018 via email

@icarlossz
Copy link
Contributor

@luchux Creo que faltaban un par de cambios por acá:
#24

@icarlossz
Copy link
Contributor

Complete and proofread Spanish translation without problems. 🔥

@domyen
Copy link
Member Author

domyen commented Jun 13, 2018

This is awesome @icarlossz and @luchux! @tmeasday and I are currently working on the associated changes to support this in #28. Should have a path forward by end of week. I'll aim to release the Spanish version sometime next week.

@icarlossz
Copy link
Contributor

Awesome! 💯

@luchux
Copy link
Contributor

luchux commented Jun 14, 2018 via email

@domyen
Copy link
Member Author

domyen commented Jun 15, 2018

We released a first cut of the Spanish version to master (link)!
There will likely be a few tweaks necessary. Let's test and let it settle for a few days.

Known issues:

  • Twitter message is not translated (it's currently a part of the template not content)
  • Language picker can be hard to find

Edit: made adjustment to callout languages clearly on homepage

@luchux
Copy link
Contributor

luchux commented Jun 19, 2018

Should we may be translate as well some images? Can send texts for them.
i.e. attached

@icarlossz
Copy link
Contributor

@domyen You have the assets of the images for translate them, too? 🤓

@domyen
Copy link
Member Author

domyen commented Dec 19, 2018

Closing this. Keeping track of all the image versions is probably out of scope right now because it adds more maintenance surface area. I want to make releasing new editions and updates as easy as possible for contributors. 🙏

@domyen domyen closed this as completed Dec 19, 2018
jonniebigodes pushed a commit that referenced this issue Nov 13, 2020
* Original text of Chapter 6

* Add translated text on Chanpter6

* Update chapter6

* Revise chapter6 to the latest
jonniebigodes pushed a commit that referenced this issue Jun 17, 2022
* Translate addons

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants