chore: design systems for developers portuguese translation #183
Conversation
|
Awesome work! Let's get a proofread and then merge it in. @fabioscsilva @stephanbm you expressed interest in a Portuguese translation, would you proofread this translation? (I'm aware that there might be some differences between Brazilian PT and Portuguese PT) |
|
@domyen glad that i was able to help out and expand the documentation further! I'm fully aware that probably some items, like accents might have been forgotten, but i'm waiting to hear from both @fabioscsilva and @stephanbm for their input, so that we can fine tune even more the documentation so that it reaches a broader audience. |
|
Nice one! Will also try to provide some feedback in the next day or two ;) |
|
@joaogarin looking forward for your input aswell. The more input the better so that this document can move forward. |
|
@domyen i did a bit more digging and it seems that i was correct on the word choosing. The item raised in the comments would mislead the readers, as with the agreement both audiences are using the word "estória" which translates to "story" and história " which translates to history", before the agreement the word "história" was used for both scenarios. Don't ask me why they went with the partition, i'm not a linguist in any shape or form, i just go with it 😃! I think that we're ready for merging this. Feel free to provide feedback |
Sure, I will take a look. I will assume that this is PT-PT |
There was a problem hiding this comment.
I would suggest to you that before we comment every misspelling or new Portuguese Orthographic Agreement, that you install a spell checker and run it first and then we could continue the review. What do you think? I don't know which IDE you use, but for instance in Visual Code you can install this Portuguese - Code Spell Checker for instance. If you need help with it, let me know.
|
@fabioscsilva thank you for the time and spotting the mishaps in the documentation. The documentation was written under the agreement, oriented to a pt-pt audience, but factoring in the brazilian audience aswell. This, to avoid having having multiple copies of the same documentation in the repo, that are basically the same and with that bloating it unnecessarily. 👍 |
|
@jonniebigodes have you tried my suggestion? There are more issues, that you could spot with a Code Spell Checker |
|
i've installed it and using it as i type this. It seems that the spell checker i was using, was doing a bad job. And was introducing alot and by alot i mean a tremendous ammount of grammar errors. I'm going to run it by this spell checker and remove the other one and update the documentation. Thank for bring this to my attention. Edit: It seems that my earlier spell checker started messing up when some words were added to be ignored and when i ran it it started acting up. Re ran it with this spell checker and it seems that the the errors that were introduced are now resolved. |
|
Nice job! Looks good to me! Thank you for your contribution! |
|
@domyen we're good to go. When you're able could you merge this? |
|
Thanks! Merged :) |
This pr introduces the portuguese translation for the guide "Design Systems for Developers".
The only significant change worth of notice is the syntax highlight associated to the mdx files located in the "document" section. Instead of using javascript for it, as it could highlight the code in a strange way, for instance the word "default", i modified it to mdx to match the type.
Feel free to provide feedback.