[1.3] Fix Mouse::find() after cursor has moved
#320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this breaks |
|
The |
|
@enricodias yes but it was not working before either I think. I was just a coincidence. |
simPod
force-pushed
the
fix-find
branch
5 times, most recently
from
d689f15
to
d1346e0
Compare
After scrolling to the element, its boundaries change and we have to read the viewport offsets in order to compute final coordinates.
|
now I like it |
enricodias
approved these changes
Jan 20, 2022
GrahamCampbell
requested changes
Jan 21, 2022
Closed
GrahamCampbell
changed the title
Mouse::find() after cursor has movedMouse::find() after cursor has moved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After scrolling to the element, its boundaries change and we have to read the viewport offsets in order to compute final coordinates.