Page layout metrics

[kaero598]

The missing Page.getLayoutMetrics feature is the only thing that prevents taking full-size screenshots.

[gsouf]

Hi @kaero598,
that's a great first contribution, thanks!

I'll just add one more scenario in unit tests because you're testing the window size, but you don't test the case where the layout is larger than the window.

[gsouf]

@kaero598 I added a comment, I'll wait for your response before I go ahead

[kaero598]

@gsouf Nice catch. I made #45 covering this scenario.

[gsouf]

@kaero598 Thanks, but I did it already, but didn't push yet as I was waiting for your answer about the LayoutMetricFailed excption

[kaero598]

@gsouf That's was confusing because I didn't see your comment. Where can I find it?

[gsouf]

Can you see the review here https://github.com/chrome-php/headless-chromium-php/pull/43/files#diff-472fd206a8e051d0df4d751280094c81R35

[kaero598]

Nope. I see code changes and no comments. Your link just highlights the line before exception is thrown.

[gsouf]

Sorry I never used that new review tool. I guess you can see it now