Add GetBrowserPid option to browser.go #566
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't get what the purpose here is. Can you provide an example? Also, the API seems pretty stiff. Why not expose https://golang.org/pkg/os/#Process? We could expose and document the field in |
|
Friendly ping @Ajod. This would also need a test before merging. |
mvdan
suggested changes
May 29, 2020
|
Hi, based on your comment that it might not have a purpose I eventually ended up not needing to expose the PID or the Process at all. This would probably a somewhat pointless PR and I should probably close it if that is okay with you |
|
Sounds good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process PID can come in handy when there is talk about running a third party software against a remotely controlled browser.
New PR from clean fork