This repository has been archived by the owner on Jan 15, 2023. It is now read-only.
Update DefaultResourceSchemeHandler.cs #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProcessRequestAsync return 404 if the request local file dose not exitst and avoid stuck pending
amaitland
reviewed
Oct 30, 2020
| return CefReturnValue.ContinueAsync; | ||
| else | ||
| { | ||
| StatusCode = (int)HttpStatusCode.NotFound; |
There was a problem hiding this comment.
I'd suggest populating the Stream with an error message otherwise you'll end up with a blank page displayed to the user if they request a file that's not found.
You can use ResourceHandler.GetMemoryStream to turn a string into a stream.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProcessRequestAsync return 404 if the request local file dose not exitst and avoid stuck pending