Skip to content

Commit

Permalink
[M118][Gardener] Disable ChromeWebPlatformSecurityMetricsBrowserTest.…
Browse files Browse the repository at this point in the history
…DanglingMarkupInTargetWithNewLineOrGreaterThan on Mac devices

The test was consistently failing on m118 Mac builds.

(cherry picked from commit 70a0f92)

Bug: 1487325
Change-Id: Ifb0a2436f7e36f08004389d2204065a0ba1ddd34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4930890
Owners-Override: Vidhan Jain <vidhanj@google.com>
Reviewed-by: Adem Derinel <derinel@google.com>
Commit-Queue: Vidhan Jain <vidhanj@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1208151}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4948066
Auto-Submit: Elaine Chien <elainechien@chromium.org>
Owners-Override: Elaine Chien <elainechien@google.com>
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Owners-Override: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/branch-heads/5993@{#1324}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
  • Loading branch information
Vidhan authored and Chromium LUCI CQ committed Oct 17, 2023
1 parent d099b5f commit 0048ae3
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions chrome/browser/chrome_web_platform_security_metrics_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2369,8 +2369,16 @@ IN_PROC_BROWSER_TEST_F(ChromeWebPlatformSecurityMetricsBrowserTest,
CheckCounter(WebFeature::kDanglingMarkupInTargetNotEndsWithNewLineOrGT, 0);
}

IN_PROC_BROWSER_TEST_F(ChromeWebPlatformSecurityMetricsBrowserTest,
DanglingMarkupInTargetWithNewLineOrGreaterThan) {
// TODO(https://crbug.com/1487325): Fix and reenable the test for Mac.
#if BUILDFLAG(IS_MAC)
#define MAYBE_DanglingMarkupInTargetWithNewLineOrGreaterThan \
DISABLED_DanglingMarkupInTargetWithNewLineOrGreaterThan
#else
#define MAYBE_DanglingMarkupInTargetWithNewLineOrGreaterThan \
DanglingMarkupInTargetWithNewLineOrGreaterThan
#endif
IN_PROC_BROWSER_TEST_F(ChromeWebPlatformSecurityMetricsBrowserTest,
MAYBE_DanglingMarkupInTargetWithNewLineOrGreaterThan) {
GURL url = https_server().GetURL("a.test", "/empty.html");
EXPECT_TRUE(content::NavigateToURL(web_contents(), url));
EXPECT_TRUE(content::ExecJs(web_contents(), R"(
Expand Down

0 comments on commit 0048ae3

Please sign in to comment.