Skip to content

Commit

Permalink
Quick Delete: Fix recent tabs not detected after restart
Browse files Browse the repository at this point in the history
The last navigation committed timestamp for tabs is not restored
correctly, causing all tabs to have INVALID_TIMESTAMP set for this field, which causes them to be undetected for deletion by QuickDeleteTabsFilter.

This CL ensures that the lastNavigationCommittedTimestamp is updated
with the correct value on restore.

(cherry picked from commit 407915f)

(cherry picked from commit 407915f)

Bug: 1475969, b/300055041
Change-Id: I8cf2404b72ea864b13fdfc16fe33a74b318c198b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4890332
Commit-Queue: Zaina Al-Mashni <zalmashni@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1202386}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4906128
Cr-Commit-Position: refs/branch-heads/5993@{#1048}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
  • Loading branch information
Zaina Al-Mashni authored and Chromium LUCI CQ committed Oct 2, 2023
1 parent d9c64ef commit 00fdc8c
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1010,6 +1010,8 @@ void restoreFieldsFromState(TabState state) {
assert state != null;
CriticalPersistedTabData.from(this).setWebContentsState(state.contentsState);
CriticalPersistedTabData.from(this).setTimestampMillis(state.timestampMillis);
CriticalPersistedTabData.from(this).setLastNavigationCommittedTimestampMillis(
state.lastNavigationCommittedTimestampMillis);
CriticalPersistedTabData.from(this).setUrl(
new GURL(state.contentsState.getVirtualUrlFromState()));
CriticalPersistedTabData.from(this).setTitle(
Expand Down

0 comments on commit 00fdc8c

Please sign in to comment.