-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix AXTreeManager type confusion in AXPlatformNodeTextRangeProviderWin
In `AXPlatformNodeTextRangeProviderWin::GetOwner`, there is an assumption that the position's tree is an `AXPlatformTreeManager`, but there are some cases (Views) where this is not currently the case. In those cases, we can't safely cast to `AXPlatformTreeManager`. This change adds a virtual method to determine whether an AXTreeManager is an AXPlatformTreeManager to allow us to safely cast. Fixed: 1451763 Change-Id: I65ebae42d200aaddbfe914e54a2c5fcb69974205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599972 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1155268}
- Loading branch information
1 parent
8368cca
commit 028d1e2
Showing
6 changed files
with
40 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
// Copyright 2023 The Chromium Authors | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
#include "ui/accessibility/platform/ax_platform_tree_manager.h" | ||
|
||
namespace ui { | ||
|
||
bool AXPlatformTreeManager::IsPlatformTreeManager() const { | ||
return true; | ||
} | ||
|
||
} // namespace ui |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters