Skip to content

Commit

Permalink
Merge M90: Fix spelling of "screen reader" for ChromeVox hint
Browse files Browse the repository at this point in the history
See the correct spelling per wikipedia:
https://en.wikipedia.org/wiki/Screen_reader

(cherry picked from commit ca56cb6)

Bug: 1185885
Change-Id: Ia6b286932d50469709013d36af4842ff2b0c83a5
AX-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2721200
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#858233}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2743324
Auto-Submit: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4430@{#261}
Cr-Branched-From: e5ce7dc-refs/heads/master@{#857950}
  • Loading branch information
akihiroota87 authored and Chromium LUCI CQ committed Mar 8, 2021
1 parent 382dc96 commit 05fc4b5
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions chrome/app/chromeos_strings.grdp
Original file line number Diff line number Diff line change
Expand Up @@ -5005,13 +5005,13 @@
No, continue without ChromeVox
</message>
<message name="IDS_OOBE_CHROMEVOX_HINT_TEXT" desc="Text content in the ChromeVox hint dialog, asking the user if they would like to activate ChromeVox.">
Do you want to activate ChromeVox, the built-in screenreader for Chrome OS?
Do you want to activate ChromeVox, the built-in screen reader for Chrome OS?
</message>
<message name="IDS_OOBE_CHROMEVOX_HINT_ANNOUNCEMENT_TEXT_LAPTOP" desc="The string spoken when the ChromeVox hint is activated when the device is in laptop mode." is_accessibility_with_no_ui="true">
Do you want to activate ChromeVox, the built-in screenreader for Chrome OS? If so, press the space bar.
Do you want to activate ChromeVox, the built-in screen reader for Chrome OS? If so, press the space bar.
</message>
<message name="IDS_OOBE_CHROMEVOX_HINT_ANNOUNCEMENT_TEXT_TABLET" desc="The string spoken when the ChromeVox hint is activated when the device is in tablet mode." is_accessibility_with_no_ui="true">
Do you want to activate ChromeVox, the built-in screenreader for Chrome OS? If so, press and hold both volume keys for five seconds.
Do you want to activate ChromeVox, the built-in screen reader for Chrome OS? If so, press and hold both volume keys for five seconds.
</message>

<!-- Mojo service names (displayed in task manager) -->
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
da17d6a1994112da932327cfc8f1812ac2500b69
d7a338f394773a56a5778c7664f4350a32b3b984
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ const char kSetAvailableVoices[] = R"(
};)";

const char kChromeVoxHintLaptopSpokenString[] =
"Do you want to activate ChromeVox, the built-in screenreader for Chrome "
"Do you want to activate ChromeVox, the built-in screen reader for Chrome "
"OS? If so, press the space bar.";

void ToggleAccessibilityFeature(const std::string& feature_name,
Expand Down Expand Up @@ -619,8 +619,8 @@ IN_PROC_BROWSER_TEST_F(WelcomeScreenChromeVoxHintTest, Tablet) {
test::SpeechMonitor monitor;
welcome_screen()->GiveChromeVoxHintForTesting();
monitor.ExpectSpeech(
"Do you want to activate ChromeVox, the built-in screenreader for Chrome "
"OS? If so, press and hold both volume keys for five seconds.");
"Do you want to activate ChromeVox, the built-in screen reader for "
"Chrome OS? If so, press and hold both volume keys for five seconds.");
monitor.Replay();
WaitForSpokenSuccessMetric();
}
Expand Down

0 comments on commit 05fc4b5

Please sign in to comment.