Skip to content

Commit

Permalink
media: disable VP9 k-SVC hw encoding by default in Lacros
Browse files Browse the repository at this point in the history
Zero copy video capture is currently disabled in Lacros so VP9 k-SVC
encoding should be disabled too since it only works with zero copy video
capture.

This change will fix some vaapi encoder crashes that have been reported
when using Meet in Lacros.

BUG=b:214589754, 1286935, 1285758
TEST=manual test in volteer

(cherry picked from commit 1130998)

Change-Id: Ic970dd01da26f61007f07d8c0cab530ef387b05e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3530367
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Pilar Molina Lopez <pmolinalopez@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#981955}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3542748
Auto-Submit: Pilar Molina Lopez <pmolinalopez@google.com>
Owners-Override: Srinivas Sista <srinivassista@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4896@{#797}
Cr-Branched-From: 1f63ff4-refs/heads/main@{#972766}
  • Loading branch information
Pilar Molina Lopez authored and Chromium LUCI CQ committed Mar 22, 2022
1 parent a1d7aaa commit 093e74f
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions media/base/media_switches.cc
Expand Up @@ -529,8 +529,14 @@ const base::Feature kVaapiH264TemporalLayerHWEncoding{
const base::Feature kVaapiVp8TemporalLayerHWEncoding{
"VaapiVp8TemporalLayerEncoding", base::FEATURE_DISABLED_BY_DEFAULT};
// Enable VP9 k-SVC encoding with HW encoder for webrtc use case on ChromeOS.
const base::Feature kVaapiVp9kSVCHWEncoding{"VaapiVp9kSVCHWEncoding",
base::FEATURE_ENABLED_BY_DEFAULT};
const base::Feature kVaapiVp9kSVCHWEncoding {
"VaapiVp9kSVCHWEncoding",
#if BUILDFLAG(IS_CHROMEOS_ASH)
base::FEATURE_ENABLED_BY_DEFAULT
#else
base::FEATURE_DISABLED_BY_DEFAULT
#endif // BUILDFLAG(IS_CHROMEOS_ASH)
};
#endif // defined(ARCH_CPU_X86_FAMILY) && BUILDFLAG(IS_CHROMEOS)

// Inform video blitter of video color space.
Expand Down

0 comments on commit 093e74f

Please sign in to comment.