Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix ChromeNetworkServiceBrowserTest.EncryptedCookies on Windows
This test has not been working on Windows and the root cause was that the data migration code in content/browser/network_sandbox.cc was deleting the file called 'cookies' because NTFS used case-insensitive matching for the 'old' cookie file. This migration caused the test 'cookies' file created within the PRE_ fixture to be copied and deleted on the start of the non-PRE fixture when creating the default network context, since the migration code believed it to be an old cookies file as it was contained in the `unsandboxed_data_path` and migration had occurred. This always caused there to be no cookies in the 'cookies' database, since it no longer existing on disk by the time that the test started executing. This only had effect on platforms that supplied both an `unsandboxed_data_path` and also specified `trigger_migration` to be true, which happened to only be Windows. Renaming the file to something other than 'cookies' fixes this issue, since the migration code is still needed. The macOS failures are likely a different root cause but the test can be re-enabled on macOS in a future CL. BUG=868667 Change-Id: Icf453d16ec2324d65cf00074baa1e6c266f871b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4985832 Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/main@{#1216631}
- Loading branch information