Skip to content

Commit

Permalink
[CrossThreadHandle] Convert third_party/blink/renderer/core/paint/pai…
Browse files Browse the repository at this point in the history
…nt_timing.cc

This is part of a cleanup task to make memory safer when data isn't used
cross thread, but is instead merely passed to be used back again on the
originating thread. Design doc:
https://docs.google.com/document/d/1GIT0ysdQ84sGhIo1r9EscF_fFt93lmNVM_q4vvHj2FQ/edit#

Bug: 1377345
Change-Id: I18467b519da52ac14aa4adc4eb2bb976665fb7a0

fuzzer infra failure

No-Try: true
Change-Id: I18467b519da52ac14aa4adc4eb2bb976665fb7a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4047900
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1075899}
  • Loading branch information
arichiv authored and Chromium LUCI CQ committed Nov 26, 2022
1 parent 50dd2b0 commit 0ec0355
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions third_party/blink/renderer/core/paint/timing/paint_timing.cc
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include "third_party/blink/renderer/core/timing/performance_timing_for_reporting.h"
#include "third_party/blink/renderer/core/timing/window_performance.h"
#include "third_party/blink/renderer/platform/graphics/paint/ignore_paint_timing_scope.h"
#include "third_party/blink/renderer/platform/heap/cross_thread_handle.h"
#include "third_party/blink/renderer/platform/instrumentation/resource_coordinator/document_resource_coordinator.h"
#include "third_party/blink/renderer/platform/instrumentation/tracing/trace_event.h"
#include "third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h"
Expand Down Expand Up @@ -268,7 +269,7 @@ void PaintTiming::SetFirstContentfulPaint(base::TimeTicks stamp) {
void PaintTiming::RegisterNotifyPresentationTime(PaintEvent event) {
RegisterNotifyPresentationTime(
CrossThreadBindOnce(&PaintTiming::ReportPresentationTime,
WrapCrossThreadWeakPersistent(this), event));
MakeUnwrappingCrossThreadWeakHandle(this), event));
}

void PaintTiming::
Expand All @@ -277,7 +278,7 @@ void PaintTiming::
RegisterNotifyPresentationTime(CrossThreadBindOnce(
&PaintTiming::
ReportFirstPaintAfterBackForwardCacheRestorePresentationTime,
WrapCrossThreadWeakPersistent(this), index));
MakeUnwrappingCrossThreadWeakHandle(this), index));
}

void PaintTiming::RegisterNotifyPresentationTime(ReportTimeCallback callback) {
Expand Down

0 comments on commit 0ec0355

Please sign in to comment.