Skip to content

Commit

Permalink
Revert "[LCPP] LCP ScriptObserver web_tests."
Browse files Browse the repository at this point in the history
This reverts commit c650d59.

Reason for revert: Consistently failing test (first build): https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20ASAN/50226/overview

Original change's description:
> [LCPP] LCP ScriptObserver web_tests.
>
> This CL adds test cases for crrev.com/c/4651499. The tests assert
> that LCPScriptObserver's HTMLImageElement script dependency feature
> works as expected in different scenarios that involve async scripts.
>
> Bug: 1419756
> Change-Id: Id60df6649cccaf35f51acbd86995c96a08fcd897
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4767918
> Reviewed-by: Weizhong Xia <weizhong@google.com>
> Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1187099}

Bug: 1419756
Change-Id: Ia30b3726e15c10e6c84c8295b9e9800ff6cc37c1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4803711
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Andy Paicu <andypaicu@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1187168}
  • Loading branch information
andypaicu authored and Chromium LUCI CQ committed Aug 23, 2023
1 parent 1cf8eb2 commit 0fc329b
Show file tree
Hide file tree
Showing 14 changed files with 0 additions and 211 deletions.
5 changes: 0 additions & 5 deletions third_party/blink/renderer/core/testing/internals.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4046,9 +4046,4 @@ void Internals::setBackForwardCacheRestorationBufferSize(unsigned int maxSize) {
perf.setBackForwardCacheRestorationBufferSizeForTest(maxSize);
}

Vector<String> Internals::getCreatorScripts(HTMLImageElement* img) {
DCHECK(img);
return Vector<String>(img->creator_scripts());
}

} // namespace blink
5 changes: 0 additions & 5 deletions third_party/blink/renderer/core/testing/internals.h
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ class StaticSelection;
class Text;
class TypeConversions;
class UnionTypesTest;
class HTMLImageElement;

template <typename NodeType>
class StaticNodeTypeList;
Expand Down Expand Up @@ -643,10 +642,6 @@ class Internals final : public ScriptWrappable {

InternalsUkmRecorder* initializeUKMRecorder();

// Returns scripts that created an image, as observed by
// the LCPScriptObserver Probe.
Vector<String> getCreatorScripts(HTMLImageElement* img);

private:
Document* ContextDocument() const;
Vector<String> IconURLs(Document*, int icon_types_mask) const;
Expand Down
2 changes: 0 additions & 2 deletions third_party/blink/renderer/core/testing/internals.idl
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,4 @@ interface Internals {
void setAllowPerChunkTransferring(ReadableStream stream);

void setBackForwardCacheRestorationBufferSize(long maxSize);

sequence<DOMString> getCreatorScripts(HTMLImageElement img);
};
20 changes: 0 additions & 20 deletions third_party/blink/web_tests/VirtualTestSuites
Original file line number Diff line number Diff line change
Expand Up @@ -2430,26 +2430,6 @@
"kouhei@chromium.org"
]
},
{
"prefix": "lcp-script-observer",
"platforms": [
"Linux",
"Mac",
"Win"
],
"bases": [
"http/tests/lcp-script-observer"
],
"exclusive_tests": "ALL",
"args": [
"--enable-features=LCPCriticalPathPredictor,LCPScriptObserver"
],
"expires": "Sep 10, 2024",
"owners": [
"alexnj@chromium.org",
"kouhei@chromium.org"
]
},
{
"prefix": "fetch-later",
"platforms": ["Linux", "Mac", "Win"],
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit 0fc329b

Please sign in to comment.