Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Merge to M101] [Topics] Implement BrowsingTopicsCalculator
- Implement BrowsingTopicsCalculator. It’s responsible for doing a one-off browsing topics calculation. The calculation will occur every 7 days. See the class comment for details. - Rename “top_host” to “main_frame_host” to be more clear. This is fine with database schema as well, as currently there’s no way to initialize the database tables (even with feature flags). - Let PageContentAnnotationsService::BatchAnnotatePageTopics accept the hosts instead of GURL. - Move GetModelInfoForType() to the PageContentAnnotator interface, so that the model version can be mocked in tests as well. Explainer: https://github.com/jkarlin/topics Design doc: https://docs.google.com/document/d/12UEo6PgeySUgEpkaAoawPjhjR0GSz-XhSOXSmrMxV6U PoC CL: https://chromium-review.googlesource.com/c/chromium/src/+/3416117 (cherry picked from commit c95d315) Bug: 1294456 Change-Id: I13aba4d32a0e3377295f926a5ddb2168417d8c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3511510 Reviewed-by: Josh Karlin <jkarlin@chromium.org> Reviewed-by: Robert Ogden <robertogden@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Sophie Chang <sophiechang@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#982586} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553239 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/branch-heads/4951@{#171} Cr-Branched-From: 27de622-refs/heads/main@{#982481}
- Loading branch information