-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Password Manager] Add all possible promo dialogs for MVP
This CL adds 4 promo cards implementations. For password checkup(shown only if there are saved passwords), managing passwords on passwords.google.com (shown only if password syncing is enabled), for creating a shortcut (shown only if shortcut was not created before) and for how to use Password Manager on Android and iOS. Promo dialogs shares the same behaviour as bubbles in regards that they are never shown again if the user explicitly dismissed them or if they have been shown for 3 times already. The only exception is Password Checkup promo card which should be shown regularly. See more: https://docs.google.com/document/d/1MW-54YAiy1osHqWwZlX4QG3GusTCZsiAIZCjuNj963Y/edit# Bug: 1423346 Change-Id: I6ddbfee8613d8dd43fa9ba308953397a098696d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4334456 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/main@{#1119848}
- Loading branch information
Viktor Semeniuk
authored and
Chromium LUCI CQ
committed
Mar 21, 2023
1 parent
7b4709d
commit 1595e16
Showing
15 changed files
with
639 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
...anager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_ANY_DEVICE_PROMO_CARD_DESCRIPTION.png.sha1
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
16c190fb9a5a097594830e096cd021d8e861edb7 |
1 change: 1 addition & 0 deletions
1
...word_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_ANY_DEVICE_PROMO_CARD_TITLE.png.sha1
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
16c190fb9a5a097594830e096cd021d8e861edb7 |
1 change: 1 addition & 0 deletions
1
...ssword_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_CHECKUP_PROMO_CARD_ACTION.png.sha1
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
2cc2616cbd8fef4e36520ff88d05b36bdc7640fb |
1 change: 1 addition & 0 deletions
1
...d_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_CHECKUP_PROMO_CARD_DESCRIPTION.png.sha1
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
2cc2616cbd8fef4e36520ff88d05b36bdc7640fb |
1 change: 1 addition & 0 deletions
1
...assword_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_CHECKUP_PROMO_CARD_TITLE.png.sha1
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
2cc2616cbd8fef4e36520ff88d05b36bdc7640fb |
1 change: 1 addition & 0 deletions
1
..._manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_SHORTCUT_PROMO_CARD_DESCRIPTION.png.sha1
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
7350bf5147725b786f75193a89de6bcb4d8f0c60 |
1 change: 1 addition & 0 deletions
1
...ssword_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_SHORTCUT_PROMO_CARD_TITLE.png.sha1
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
7350bf5147725b786f75193a89de6bcb4d8f0c60 |
1 change: 1 addition & 0 deletions
1
...sword_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_WEB_PROMO_CARD_DESCRIPTION.png.sha1
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
32a40d9c3b823c8d6dc9688541d9af53c62d7809 |
1 change: 1 addition & 0 deletions
1
...pp/password_manager_ui_strings_grdp/IDS_PASSWORD_MANAGER_UI_WEB_PROMO_CARD_TITLE.png.sha1
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
32a40d9c3b823c8d6dc9688541d9af53c62d7809 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.