[RCTS] Add unit test for TabInteractionRecorderAndroid

Add basic unit tests that were missing on Android side. Bug: 1322240 Change-Id: I5c917a22af4110e51c1bef9b5e2b208924f90608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4018733 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Commit-Queue: Theresa Sullivan <twellington@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1070583}
chromium · Nov 12, 2022 · 183284e · 183284e
1 parent b5879c7
commit 183284e
Show file tree

Hide file tree

Showing 3 changed files with 116 additions and 0 deletions.
diff --git a/chrome/android/chrome_junit_test_java_sources.gni b/chrome/android/chrome_junit_test_java_sources.gni
@@ -112,6 +112,7 @@ chrome_junit_test_java_sources = [
   "junit/src/org/chromium/chrome/browser/customtabs/content/CustomTabActivityUrlLoadingTest.java",
   "junit/src/org/chromium/chrome/browser/customtabs/content/RealtimeEngagementSignalObserverUnitTest.java",
   "junit/src/org/chromium/chrome/browser/customtabs/features/ImmersiveModeControllerTest.java",
+  "junit/src/org/chromium/chrome/browser/customtabs/features/TabInteractionRecorderUnitTest.java",
   "junit/src/org/chromium/chrome/browser/customtabs/features/sessionrestore/SessionRestoreManagerUnitTest.java",
   "junit/src/org/chromium/chrome/browser/customtabs/features/sessionrestore/SessionRestoreMessageControllerUnitTest.java",
   "junit/src/org/chromium/chrome/browser/customtabs/features/toolbar/BrandingSecurityButtonAnimationDelegateUnitTest.java",

diff --git a/...roid/java/src/org/chromium/chrome/browser/customtabs/features/TabInteractionRecorder.java b/...roid/java/src/org/chromium/chrome/browser/customtabs/features/TabInteractionRecorder.java
@@ -40,6 +40,11 @@ private TabInteractionRecorder(long nativePtr) {
         mNativeTabInteractionRecorder = nativePtr;
     }
 
+    @VisibleForTesting
+    TabInteractionRecorder() {
+        this(1L);
+    }
+
     @CalledByNative
     private static @Nullable TabInteractionRecorder create(long nativePtr) {
         if (nativePtr == 0) return null;

diff --git a/...t/src/org/chromium/chrome/browser/customtabs/features/TabInteractionRecorderUnitTest.java b/...t/src/org/chromium/chrome/browser/customtabs/features/TabInteractionRecorderUnitTest.java
@@ -0,0 +1,110 @@
+// Copyright 2022 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.customtabs.features;
+
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.junit.MockitoJUnit;
+import org.mockito.junit.MockitoRule;
+
+import org.chromium.base.test.BaseRobolectricTestRunner;
+import org.chromium.base.test.util.JniMocker;
+import org.chromium.chrome.browser.preferences.ChromePreferenceKeys;
+import org.chromium.chrome.browser.preferences.SharedPreferencesManager;
+import org.chromium.chrome.browser.tab.Tab;
+
+/** Unit test for {@link TabInteractionRecorder} on the java side. */
+@RunWith(BaseRobolectricTestRunner.class)
+public class TabInteractionRecorderUnitTest {
+    @Rule
+    public MockitoRule mMockitoRule = MockitoJUnit.rule();
+
+    @Rule
+    public JniMocker mJniMocker = new JniMocker();
+
+    @Mock
+    Tab mTab;
+
+    private TestNativeInteractionRecorder mTestNative;
+    private TabInteractionRecorder mTestRecorder;
+    private SharedPreferencesManager mPref;
+
+    @Before
+    public void setup() {
+        mTestNative = new TestNativeInteractionRecorder();
+        mJniMocker.mock(TabInteractionRecorderJni.TEST_HOOKS, mTestNative);
+        mPref = SharedPreferencesManager.getInstance();
+
+        TabInteractionRecorder.createForTab(mTab);
+        TabInteractionRecorder recorder = TabInteractionRecorder.getFromTab(mTab);
+        Assert.assertNotNull("Recorder not created.", recorder);
+    }
+
+    @After
+    public void tearDown() {
+        mPref.removeKey(ChromePreferenceKeys.CUSTOM_TABS_LAST_CLOSE_TAB_INTERACTION);
+        mPref.removeKey(ChromePreferenceKeys.CUSTOM_TABS_LAST_CLOSE_TIMESTAMP);
+    }
+
+    @Test
+    public void hadInteractionOnTabClosing() {
+        mTestNative.paramHadInteraction = true;
+        TabInteractionRecorder.getFromTab(mTab).onTabClosing();
+
+        Assert.assertTrue("Shared pref <CUSTOM_TABS_LAST_CLOSE_TAB_INTERACTION> is not recorded.",
+                mPref.contains(ChromePreferenceKeys.CUSTOM_TABS_LAST_CLOSE_TAB_INTERACTION));
+        Assert.assertTrue("Value of shared pref <CUSTOM_TABS_LAST_CLOSE_TAB_INTERACTION> is wrong.",
+                mPref.readBoolean(
+                        ChromePreferenceKeys.CUSTOM_TABS_LAST_CLOSE_TAB_INTERACTION, false));
+        Assert.assertTrue("Shared pref <CUSTOM_TABS_LAST_CLOSE_TIMESTAMP> is not recorded.",
+                mPref.contains(ChromePreferenceKeys.CUSTOM_TABS_LAST_CLOSE_TIMESTAMP));
+    }
+
+    @Test
+    public void noInteractionOnTabClosing() {
+        mTestNative.paramHadInteraction = false;
+        TabInteractionRecorder.getFromTab(mTab).onTabClosing();
+
+        Assert.assertTrue("Shared pref <CUSTOM_TABS_LAST_CLOSE_TAB_INTERACTION> is not recorded.",
+                mPref.contains(ChromePreferenceKeys.CUSTOM_TABS_LAST_CLOSE_TAB_INTERACTION));
+        Assert.assertFalse(
+                "Value of shared pref <CUSTOM_TABS_LAST_CLOSE_TAB_INTERACTION> is wrong.",
+                mPref.readBoolean(
+                        ChromePreferenceKeys.CUSTOM_TABS_LAST_CLOSE_TAB_INTERACTION, false));
+        Assert.assertTrue("Shared pref <CUSTOM_TABS_LAST_CLOSE_TIMESTAMP> is not recorded.",
+                mPref.contains(ChromePreferenceKeys.CUSTOM_TABS_LAST_CLOSE_TIMESTAMP));
+    }
+
+    class TestNativeInteractionRecorder implements TabInteractionRecorder.Natives {
+        public boolean paramDidGetUserInteraction;
+        public boolean paramHadInteraction;
+
+        @Override
+        public TabInteractionRecorder getFromTab(Tab tab) {
+            return mTestRecorder;
+        }
+
+        @Override
+        public TabInteractionRecorder createForTab(Tab tab) {
+            mTestRecorder = new TabInteractionRecorder();
+            return mTestRecorder;
+        }
+
+        @Override
+        public boolean didGetUserInteraction(long nativeTabInteractionRecorderAndroid) {
+            return paramDidGetUserInteraction;
+        }
+
+        @Override
+        public boolean hadInteraction(long nativeTabInteractionRecorderAndroid) {
+            return paramHadInteraction;
+        }
+    }
+}