Skip to content

Commit

Permalink
[css-flex] Cleanup TestExpectations
Browse files Browse the repository at this point in the history
Just bookkeeping, no behavior changes.

* Give a failure a real bug instead of the generic importer bug
* Change 1114306's failure to expected.txt so we don't regress
  other cases
* Move some lines around
* Update disable-layout-ng

Bug: 1114306
Fixed: 1218278
Change-Id: Ia55047ec7fc4aa364c0c87ee9d05ffcdc87d1ff7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2955003
Auto-Submit: David Grogan <dgrogan@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892241}
  • Loading branch information
davidsgrogan authored and Chromium LUCI CQ committed Jun 14, 2021
1 parent 61adef1 commit 1d5891c
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,14 @@ crbug.com/553838 external/wpt/css/css-flexbox/flexbox-min-height-auto-002a.html
crbug.com/553838 external/wpt/css/css-flexbox/flexbox-min-height-auto-002c.html [ Failure ]
crbug.com/1132627 external/wpt/css/css-flexbox/flexbox-min-width-auto-002a.html [ Failure ]
crbug.com/1132627 external/wpt/css/css-flexbox/flexbox-min-width-auto-002c.html [ Failure ]
crbug.com/591099 external/wpt/css/css-flexbox/image-as-flexitem-size-001v.html [ Failure Pass ]
crbug.com/591099 external/wpt/css/css-flexbox/image-as-flexitem-size-003.html [ Failure ]
crbug.com/591099 external/wpt/css/css-flexbox/image-as-flexitem-size-003v.html [ Failure ]
crbug.com/591099 external/wpt/css/css-flexbox/image-as-flexitem-size-004.html [ Failure ]
crbug.com/591099 external/wpt/css/css-flexbox/image-as-flexitem-size-004v.html [ Failure ]
crbug.com/591099 external/wpt/css/css-flexbox/image-as-flexitem-size-007v.html [ Failure Pass ]
crbug.com/1162704 external/wpt/css/css-flexbox/flex-aspect-ratio-img-row-015.html [ Failure ]
crbug.com/1033476 external/wpt/css/css-flexbox/flex-minimum-height-flex-items-025.html [ Failure ]
crbug.com/1033476 external/wpt/css/css-flexbox/flex-minimum-height-flex-items-026.html [ Failure ]
crbug.com/1033476 external/wpt/css/css-flexbox/flex-minimum-width-flex-items-015.html [ Failure ]
crbug.com/1173843 external/wpt/css/css-flexbox/frameset-crash.html [ Skip ]
crbug.com/1069614 external/wpt/css/css-flexbox/overflow-area-001.html [ Failure ]
Expand All @@ -89,6 +90,7 @@ crbug.com/591099 external/wpt/css/css-flexbox/synthesize-vrl-baseline.html [ Fai
crbug.com/1181403 external/wpt/css/css-flexbox/table-as-item-inflexible-in-column-2.html [ Failure ]
crbug.com/1181403 external/wpt/css/css-flexbox/table-as-item-specified-height.html [ Failure ]
crbug.com/1181403 external/wpt/css/css-flexbox/table-as-item-min-height-1.html [ Failure ]
crbug.com/1069614 external/wpt/css/css-flexbox/overflow-top-left.html [ Failure ]

### external/wpt/css/css-fonts/
crbug.com/591099 external/wpt/css/css-fonts/font-features-across-space-1.html [ Failure ]
Expand Down Expand Up @@ -1154,7 +1156,6 @@ crbug.com/591099 editing/selection/extend/extend_selection_17_ltr_forward_linebo
crbug.com/591099 editing/selection/extend/extend_selection_17_ltr_right_lineboundary.html [ Failure ]
crbug.com/591099 external/wpt/css/CSS2/normal-flow/replaced-intrinsic-003.xht [ Failure ]
crbug.com/591099 external/wpt/css/css-flexbox/aspect-ratio-intrinsic-size-006.html [ Failure ]
crbug.com/591099 external/wpt/css/css-flexbox/flex-basis-011.html [ Failure ]
crbug.com/591099 external/wpt/css/css-flexbox/percentage-padding-002.html [ Crash ]
crbug.com/591099 external/wpt/css/css-sizing/replaced-aspect-ratio-stretch-fit-001.html [ Failure ]
crbug.com/591099 external/wpt/css/css-sizing/replaced-aspect-ratio-stretch-fit-002.html [ Failure ]
Expand Down
7 changes: 1 addition & 6 deletions third_party/blink/web_tests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -745,13 +745,8 @@ crbug.com/591099 external/wpt/css/css-ui/text-overflow-015.html [ Failure ]
crbug.com/1003506 external/wpt/css/css-flexbox/percentage-heights-007.html [ Failure ]
crbug.com/807497 external/wpt/css/css-flexbox/anonymous-flex-item-005.html [ Failure ]
crbug.com/1155036 external/wpt/css/css-flexbox/contain-size-layout-abspos-flex-container-crash.html [ Crash Pass ]
# As of Apr-19-2021, the importer hasn't imported a change to this test made 2
# weeks ago. Before the change, it passed. After the change, it will fail or
# crash. But apparently it is failing/crashing on some platforms already...?
crbug.com/1114306 external/wpt/css/css-flexbox/negative-overflow.html [ Pass Failure Crash ]

# These tests are in conflict with overflow-area-*, update them if our change is web compatible.
crbug.com/1069614 external/wpt/css/css-flexbox/overflow-top-left.html [ Failure ]
crbug.com/1069614 external/wpt/css/css-flexbox/scrollbars-auto.html [ Failure ]
crbug.com/1069614 external/wpt/css/css-flexbox/scrollbars.html [ Failure ]
crbug.com/1069614 css3/flexbox/overflow-and-padding.html [ Failure ]
Expand Down Expand Up @@ -789,6 +784,7 @@ crbug.com/336604 external/wpt/css/css-flexbox/flexbox-collapsed-item-horiz-003.h
crbug.com/336604 external/wpt/css/css-flexbox/flexbox_visibility-collapse-line-wrapping.html [ Failure ]
crbug.com/336604 external/wpt/css/css-flexbox/flexbox_visibility-collapse.html [ Failure ]

crbug.com/606208 external/wpt/css/css-flexbox/order/order-abs-children-painting-order.html [ Failure ]
# We paint in an incorrect order when layers are present. Blocked on composite-after-paint.
crbug.com/370604 external/wpt/css/css-flexbox/flexbox-paint-ordering-002.xhtml [ Failure ]

Expand Down Expand Up @@ -2547,7 +2543,6 @@ crbug.com/626703 [ Mac11.0 ] external/wpt/webauthn/getcredential-badargs-rpid.ht
crbug.com/626703 [ Mac11.0 ] external/wpt/webauthn/getcredential-badargs-userverification.https.html [ Crash Timeout ]
crbug.com/626703 [ Mac11.0 ] external/wpt/webauthn/credblob-supported.https.html [ Crash ]
crbug.com/626703 [ Mac11.0 ] external/wpt/webauthn/createcredential-large-blob-not-supported.https.html [ Crash ]
crbug.com/626703 external/wpt/css/css-flexbox/order/order-abs-children-painting-order.html [ Failure ]
crbug.com/626703 [ Mac11.0 ] external/wpt/webauthn/createcredential-extensions.https.html [ Crash Timeout ]
crbug.com/626703 external/wpt/css/css-grid/alignment/grid-content-alignment-overflow-002.html [ Failure ]
crbug.com/626703 external/wpt/webtransport/idlharness.any.worker.html [ Timeout Failure ]
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
This is a testharness.js-based test.
PASS .flexbox 1
PASS .flexbox 2
PASS .flexbox 3
PASS .flexbox 4
FAIL .flexbox 5 assert_equals:
<div class="flexbox wrap-reverse" data-expected-scroll-height="200">
<div></div>
<div></div>
</div>
scrollHeight expected 200 but got 50
PASS .flexbox 6
PASS .flexbox 7
PASS .flexbox 8
PASS .flexbox 9
PASS .flexbox 10
FAIL .flexbox 11 assert_equals:
<div class="flexbox wrap-reverse vertical-padding" data-expected-scroll-height="215">
<div></div>
<div></div>
</div>
scrollHeight expected 215 but got 65
Harness: the test ran to completion.

0 comments on commit 1d5891c

Please sign in to comment.