Add DataControlsRule parsing to ChromeDlpRulesManager

This CL adds parsing for the "DataControlsRule" policy, and creates
a vectors of `data_control::Rule`s in `ChromeDlpRulesManager`. This CL
is done in preparation of implementing the `ChromeDlpRulesManager`
public methods to work with that new policy, and as such no new tests
are added as existing behavior shouldn't change.

This CL also applies the following refactors to work:
- `DlpRulesManagerImpl::profile_` is moved to `ChromeDlpRulesManager`
- `OnPolicyUpdate` is split into `OnDataControlsRulesUpdate` and
  `OnDataLeakPreventionRulesUpdate` to independently update the two
  DLP policies as they change dynamically.
- The ctor of `DlpRulesManager` is changed to include a Profile ptr
  to pass to `ChromeDlpRulesManager`. Several tests and mocks are
  updated to reflect this.

Bug: b/302340176
Change-Id: I7744e5e64347f832c066be202a22d620c18d5cde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4935878
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1210494}

chrome/browser/ash/extensions/file_manager/file_manager_private_apitest.cc

@@ -781,7 +781,8 @@ class FileManagerPrivateApiDlpTest : public FileManagerPrivateApiTest {
 
   std::unique_ptr<KeyedService> SetDlpRulesManager(
       content::BrowserContext* context) {
-    auto dlp_rules_manager = std::make_unique<policy::MockDlpRulesManager>();
+    auto dlp_rules_manager = std::make_unique<policy::MockDlpRulesManager>(
+        Profile::FromBrowserContext(context));
     mock_rules_manager_ = dlp_rules_manager.get();
     ON_CALL(*mock_rules_manager_, IsFilesPolicyEnabled)
         .WillByDefault(testing::Return(true));

chrome/browser/ash/file_manager/app_service_file_tasks_unittest.cc

@@ -974,7 +974,8 @@ class AppServiceFileTasksPolicyTest : public AppServiceFileTasksTestEnabled {
   std::unique_ptr<KeyedService> SetDlpRulesManager(
       content::BrowserContext* context) {
     auto dlp_rules_manager =
-        std::make_unique<testing::NiceMock<policy::MockDlpRulesManager>>();
+        std::make_unique<testing::NiceMock<policy::MockDlpRulesManager>>(
+            Profile::FromBrowserContext(context));
     rules_manager_ = dlp_rules_manager.get();
     return dlp_rules_manager;
   }

chrome/browser/ash/file_manager/copy_or_move_io_task_policy_unittest.cc

@@ -1477,7 +1477,8 @@ class CopyOrMoveIOTaskWithDLPTest : public testing::Test {
   std::unique_ptr<KeyedService> SetDlpRulesManager(
       content::BrowserContext* context) {
     auto dlp_rules_manager =
-        std::make_unique<testing::NiceMock<policy::MockDlpRulesManager>>();
+        std::make_unique<testing::NiceMock<policy::MockDlpRulesManager>>(
+            Profile::FromBrowserContext(context));
     mock_rules_manager_ = dlp_rules_manager.get();
     ON_CALL(*mock_rules_manager_, IsFilesPolicyEnabled)
         .WillByDefault(testing::Return(true));

chrome/browser/ash/file_manager/file_manager_policy_browsertest.cc

@@ -81,7 +81,8 @@ class DlpFilesAppBrowserTestBase {
   std::unique_ptr<KeyedService> SetDlpRulesManager(
       content::BrowserContext* context) {
     auto dlp_rules_manager =
-        std::make_unique<testing::NiceMock<policy::MockDlpRulesManager>>();
+        std::make_unique<testing::NiceMock<policy::MockDlpRulesManager>>(
+            Profile::FromBrowserContext(context));
     mock_rules_manager_ = dlp_rules_manager.get();
     ON_CALL(*mock_rules_manager_, IsFilesPolicyEnabled)
         .WillByDefault(testing::Return(true));
@@ -352,7 +353,6 @@ class DlpFilesAppBrowserTestBase {
       chromeos::DlpClient::GetFilesSourcesCallback callback) {
     std::move(callback).Run(response);
   }
-
 };
 
 constexpr char kFileTransferConnectorSettingsForDlp[] = R"(

chrome/browser/ash/file_manager/file_tasks_browsertest.cc

@@ -742,7 +742,8 @@ class FileTasksPolicyBrowserTest : public FileTasksBrowserTest {
   std::unique_ptr<KeyedService> SetDlpRulesManager(
       content::BrowserContext* context) {
     auto dlp_rules_manager =
-        std::make_unique<testing::NiceMock<policy::MockDlpRulesManager>>();
+        std::make_unique<testing::NiceMock<policy::MockDlpRulesManager>>(
+            Profile::FromBrowserContext(context));
     rules_manager_ = dlp_rules_manager.get();
     return dlp_rules_manager;
   }

chrome/browser/ash/file_manager/restore_to_destination_io_task_unittest.cc

@@ -283,7 +283,8 @@ class RestoreToDestinationIOTaskWithDLPTest
  private:
   std::unique_ptr<KeyedService> SetDlpRulesManager(
       content::BrowserContext* context) {
-    auto dlp_rules_manager = std::make_unique<policy::MockDlpRulesManager>();
+    auto dlp_rules_manager = std::make_unique<policy::MockDlpRulesManager>(
+        Profile::FromBrowserContext(context));
     mock_rules_manager_ = dlp_rules_manager.get();
     EXPECT_CALL(*mock_rules_manager_, IsFilesPolicyEnabled)
         .WillRepeatedly(testing::Return(true));

chrome/browser/ash/policy/dlp/dlp_content_manager_ash_browsertest.cc

@@ -149,7 +149,8 @@ class DlpContentManagerAshBrowserTest : public InProcessBrowserTest {
 
   std::unique_ptr<KeyedService> SetDlpRulesManager(
       content::BrowserContext* context) {
-    auto dlp_rules_manager = std::make_unique<MockDlpRulesManager>();
+    auto dlp_rules_manager = std::make_unique<MockDlpRulesManager>(
+        Profile::FromBrowserContext(context));
     mock_rules_manager_ = dlp_rules_manager.get();
     return dlp_rules_manager;
   }

chrome/browser/ash/policy/dlp/dlp_content_manager_ash_unittest.cc

@@ -109,7 +109,8 @@ class DlpContentManagerAshTest : public testing::Test {
 
   std::unique_ptr<KeyedService> SetDlpRulesManager(
       content::BrowserContext* context) {
-    auto dlp_rules_manager = std::make_unique<MockDlpRulesManager>();
+    auto dlp_rules_manager = std::make_unique<MockDlpRulesManager>(
+        Profile::FromBrowserContext(context));
     mock_rules_manager_ = dlp_rules_manager.get();
     return dlp_rules_manager;
   }

chrome/browser/ash/policy/dlp/dlp_files_controller_ash_browsertest.cc

@@ -105,7 +105,8 @@ class DlpFilesControllerAshBrowserTest : public InProcessBrowserTest {
   std::unique_ptr<KeyedService> SetDlpRulesManager(
       content::BrowserContext* context) {
     auto dlp_rules_manager =
-        std::make_unique<testing::StrictMock<MockDlpRulesManager>>();
+        std::make_unique<testing::StrictMock<MockDlpRulesManager>>(
+            Profile::FromBrowserContext(context));
     mock_rules_manager_ = dlp_rules_manager.get();
     ON_CALL(*mock_rules_manager_, IsFilesPolicyEnabled)
         .WillByDefault(testing::Return(true));

chrome/browser/ash/policy/dlp/files_policy_notification_manager_browsertest.cc

@@ -833,7 +833,8 @@ class IOTaskBrowserTest
   std::unique_ptr<KeyedService> SetDlpRulesManager(
       content::BrowserContext* context) {
     auto dlp_rules_manager =
-        std::make_unique<testing::NiceMock<policy::MockDlpRulesManager>>();
+        std::make_unique<testing::NiceMock<policy::MockDlpRulesManager>>(
+            Profile::FromBrowserContext(context));
     mock_rules_manager_ = dlp_rules_manager.get();
     ON_CALL(*mock_rules_manager_, IsFilesPolicyEnabled)
         .WillByDefault(testing::Return(true));

chrome/browser/chromeos/BUILD.gn

@@ -150,6 +150,7 @@ source_set("chromeos") {
     "policy/dlp/dlp_policy_constants.h",
     "policy/dlp/dlp_reporting_manager.cc",
     "policy/dlp/dlp_reporting_manager.h",
+    "policy/dlp/dlp_rules_manager.cc",
     "policy/dlp/dlp_rules_manager.h",
     "policy/dlp/dlp_rules_manager_factory.cc",
     "policy/dlp/dlp_rules_manager_factory.h",