-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ntp][modules] Allow disabling individual modules in customize dialog
This CL adds various controls to the customize dialog that lets the user * Disable (hide) all modules (screenshot/8RYAASu4r9mCNPm), or * Customize modules, which means the user can disable each module individually (screenshot/5xLiE8u5M8A4YXt). The disabled state was introduced in crrev/c/2705963. This CL merges the disabled state with visibility (previous model where either all or no modules were shown) to make the model more manageable. Hereby, visible is mapped to the user can customize and hidden is mapped to all modules disabled. However, if visibility is managed by a policy, then visible is mapped to all modules enabled (screenshot/Bq2mYcVEbXiE5xX) since this is more in line with what the policy promises. Note that native code is not aware of the full set of modules and only keeps a list of disabled modules. Therefore, disabling all modules is accomplished by setting a flag rather then setting each module as disabled. Due to the merge of disabled state and visibility this CL has the nice side effect that we no longer instantiate hidden modules. Change-Id: I9ffbf5c8ee4f8e6c7ca90fe267908418c1bc9f4d Bug: 1177527 Fixed: 1148098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713395 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Esmael Elmoslimany <aee@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#858216}
- Loading branch information
Tibor Goldschwendt
authored and
Chromium LUCI CQ
committed
Feb 26, 2021
1 parent
3d25fd8
commit 21b31fd
Showing
22 changed files
with
447 additions
and
146 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
chrome/app/generated_resources_grd/IDS_NTP_CUSTOMIZE_CUSTOMIZE_CARDS_LABEL.png.sha1
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
e4e2afd525563f13c23de2ca491d2b8620fa7224 |
1 change: 1 addition & 0 deletions
1
chrome/app/generated_resources_grd/IDS_NTP_CUSTOMIZE_HIDE_ALL_CARDS_LABEL.png.sha1
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
e4e2afd525563f13c23de2ca491d2b8620fa7224 |
1 change: 0 additions & 1 deletion
1
chrome/app/generated_resources_grd/IDS_NTP_CUSTOMIZE_SHOW_MODULES_LABEL.png.sha1
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.