Skip to content

Commit

Permalink
Revert "Migrate to our own SQL base and unit tests."
Browse files Browse the repository at this point in the history
This reverts commit c9edadc.

Reason for revert: causing test failures: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cfm-rel/38119/overview

Original change's description:
> Migrate to our own SQL base and unit tests.
>
> This CL does several things:
> * Migrates to a new SQL base.
> * Split ImageInfo into two structs.
> * Moves the FilePathWorker to the AnnotationStorage's
> background sequence.
> * Adds unit test coverage for all the classes.
> * Connects the ImageAnnotationWorker to the ICA via
> mojo and uses it.
>
> images in MyFiles and unit tests."
>
> Test: "On DUT, manual search in the launcher for
> Bug: b:260646344
> Change-Id: I388caa354cbfaa0a286acbcd197c2fa1fb41ddbd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4135755
> Reviewed-by: Andrew Moylan <amoylan@chromium.org>
> Commit-Queue: Dmitry Grebenyuk <dgrebenyuk@google.com>
> Reviewed-by: Tony Yeoman <tby@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1103545}

Bug: b:260646344
Change-Id: Ia6fd7d30015c9d564d0f0ddbeb89ee665bfa99db
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4237052
Auto-Submit: Phillis Tang <phillis@chromium.org>
Owners-Override: Phillis Tang <phillis@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1103568}
  • Loading branch information
philloooo authored and Chromium LUCI CQ committed Feb 9, 2023
1 parent 3105768 commit 2223603
Show file tree
Hide file tree
Showing 13 changed files with 299 additions and 1,251 deletions.
3 changes: 0 additions & 3 deletions chrome/browser/ash/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -4767,9 +4767,6 @@ source_set("unit_tests") {
"app_list/search/help_app_zero_state_provider_unittest.cc",
"app_list/search/keyboard_shortcut_provider_unittest.cc",
"app_list/search/keyboard_shortcut_result_unittest.cc",
"app_list/search/local_images/annotation_storage_unittest.cc",
"app_list/search/local_images/image_annotation_worker_unittest.cc",
"app_list/search/local_images/sql_database_unittest.cc",
"app_list/search/omnibox/omnibox_answer_result_unittest.cc",
"app_list/search/omnibox/omnibox_lacros_provider_unittest.cc",
"app_list/search/omnibox/omnibox_provider_unittest.cc",
Expand Down

0 comments on commit 2223603

Please sign in to comment.