Skip to content

Commit

Permalink
[wpt] Update flexbox-min-width-auto-{005,006}.html
Browse files Browse the repository at this point in the history
See web-platform-tests/wpt#31609

There tests were asserting incorrect behaviour. Chrome has been shipping
the correct behaviour for a while, and believe it is web compatible.

Change-Id: I3b1177fb3fd9f9ef86a99ab050e2a7372a1ddd1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810823
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1032238}
  • Loading branch information
bfgeek authored and Chromium LUCI CQ committed Aug 6, 2022
1 parent 72ae6a9 commit 2290e4c
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 44 deletions.
Expand Up @@ -1232,6 +1232,7 @@ crbug.com/591099 paint/invalidation/scroll/sticky/invalidate-after-composited-sc
crbug.com/591099 virtual/compositor_threaded_scrollbar_scrolling/paint/invalidation/scroll/sticky/invalidate-after-composited-scroll-with-sticky.html [ Failure ]

crbug.com/591099 external/wpt/css/css-flexbox/flexbox-min-width-auto-005.html [ Failure ]
crbug.com/591099 external/wpt/css/css-flexbox/flexbox-min-width-auto-006.html [ Failure ]
crbug.com/591099 external/wpt/css/css-flexbox/flexbox_align-items-stretch-3.html [ Failure ]
crbug.com/591099 external/wpt/css/css-flexbox/percentage-heights-006.html [ Failure ]
crbug.com/591099 external/wpt/css/css-flexbox/percentage-heights-014.html [ Failure ]
Expand Down
4 changes: 0 additions & 4 deletions third_party/blink/web_tests/TestExpectations
Expand Up @@ -1506,10 +1506,6 @@ crbug.com/886585 external/wpt/css/css-flexbox/flexbox-align-self-baseline-horiz-
crbug.com/886585 external/wpt/css/css-flexbox/flexbox-align-self-baseline-horiz-007.xhtml [ Failure ]
crbug.com/886585 external/wpt/css/css-flexbox/flexbox-align-self-baseline-horiz-008.xhtml [ Failure ]

# Bad test expectations, but we aren't sure if web compatible yet.
crbug.com/1114280 external/wpt/css/css-flexbox/flexbox-min-width-auto-005.html [ Failure ]
crbug.com/1114280 external/wpt/css/css-flexbox/flexbox-min-width-auto-006.html [ Failure ]

# [css-lists]
crbug.com/1123457 external/wpt/css/css-lists/counter-list-item.html [ Failure ]
crbug.com/1123457 external/wpt/css/css-lists/counter-list-item-2.html [ Failure ]
Expand Down
Expand Up @@ -2,8 +2,8 @@
<title>CSS Flexible Box Test: Aspect ratio handling of images</title>
<link rel="author" title="Sergio Villar Senin" href="mailto:svillar@igalia.com" />
<link rel="help" href="https://drafts.csswg.org/css-flexbox-1/#min-size-auto" />
<link rel="help" href="https://github.com/web-platform-tests/wpt/issues/31609" />
<link rel="match" href="reference/flexbox-min-width-auto-005-ref.html" />
<meta name="assert" content="Test that min-width:auto does not incorrectly stretch items with aspect ratio" />

<style>
.reference-overlapped-red {
Expand All @@ -29,7 +29,7 @@

<br>

<div class="reference-overlapped-red" style="width: 40px;"></div>
<div class="reference-overlapped-red"></div>
<div style="display: flex">
<div class="constrained-flex">
<img src="support/40x20-green.png" />
Expand Down
Expand Up @@ -2,18 +2,10 @@
<title>CSS Flexible Box Test: Aspect ratio handling of images</title>
<link rel="author" title="Sergio Villar Senin" href="mailto:svillar@igalia.com" />
<link rel="help" href="https://drafts.csswg.org/css-flexbox-1/#min-size-auto" />
<link rel="help" href="https://github.com/web-platform-tests/wpt/issues/31609" />
<link rel="match" href="reference/flexbox-min-width-auto-006-ref.html" />
<meta name="assert" content="Test that min-width:auto does not incorrectly stretch items with aspect ratio" />

<style>
#reference-overlapped-red {
position: relative;
background-color: red;
width: 10px;
height: 10px;
top: 40px;
z-index: -1;
}
.constrained-width-flex {
width: 100px;
display: flex;
Expand All @@ -25,7 +17,7 @@
}
</style>

<p>Test passes if there are a (vertically centered) 20x20 and a 60x100 green boxes enclosed on each 100x100 square.</p>
<p>Test passes if there are two 100x100 green squares.</p>

<div class="constrained-width-flex">
<div class="constrained-height-flex">
Expand All @@ -42,4 +34,4 @@
<div class="constrained-height-flex">
<img src="support/60x60-green.png"/>
</div>
</div>
</div>
Expand Up @@ -7,18 +7,10 @@
height: 50px;
width: 100px;
}
span {
display: inline-block;
background-color: green;
height: 50px;
width: 40px;
}
br { margin: 50px; }
</style>

<p>Test passes if there is <strong>no red</strong> visible on the page.</p>
<div></div>

<br>

<span></span>
<div></div>
Expand Up @@ -5,28 +5,14 @@
.box {
width: 100px;
height: 100px;
background: green;
border: 1px solid black;
}
#green-square {
background: green;
margin-top: 40px;
width: 20px;
height: 20px;
}
#green-rectange {
background: green;
width: 60px;
height: 100px;
}
</style>

<p>Test passes if there are a (vertically centered) 20x20 and a 60x100 green boxes enclosed on each 100x100 square.</p>
<div class="box">
<div id="green-square"></div>
</div>
<p>Test passes if there are two 100x100 green squares.</p>
<div class="box"></div>

<br>

<div class="box">
<div id="green-rectange"></div>
</div>
<div class="box"></div>

0 comments on commit 2290e4c

Please sign in to comment.