Skip to content

Commit

Permalink
[M116] CSC: Add unit tests for VisualSearchSuggestionsService
Browse files Browse the repository at this point in the history
(cherry picked from commit 551144e)

(cherry picked from commit 551144e)

Bug: 1458250, crbug.com/1449021
Change-Id: I7391e8cd681dcaa138ff1850d7505d44edfc860c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4646683
Auto-Submit: Serena Pascual <srna@google.com>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1162795}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4687729
Commit-Queue: Serena Pascual <srna@google.com>
Cr-Commit-Position: refs/branch-heads/5845@{#491}
Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
  • Loading branch information
serenapascual authored and Chromium LUCI CQ committed Jul 14, 2023
1 parent ee35911 commit 2350552
Showing 1 changed file with 54 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -82,3 +82,57 @@ TEST_F(VisualSearchSuggestionsServiceTest, OnModelUpdated) {
*model_info_);
task_environment_.RunUntilIdle();
}

TEST_F(VisualSearchSuggestionsServiceTest,
OnModelUpdated_BadOptimizationTarget) {
VisualSearchSuggestionsService::ModelUpdateCallback callback =
base::BindOnce([](base::File model, std::string config_proto) {
EXPECT_FALSE(model.IsValid());
EXPECT_TRUE(config_proto.empty());
});
service_->OnModelUpdated(optimization_guide::proto::OptimizationTarget::
OPTIMIZATION_TARGET_TEXT_EMBEDDER,
*model_info_);
task_environment_.RunUntilIdle();
}

TEST_F(VisualSearchSuggestionsServiceTest, OnModelUpdated_InvalidModelFile) {
base::FilePath source_root_dir;
base::PathService::Get(base::DIR_SOURCE_ROOT, &source_root_dir);
std::unique_ptr<optimization_guide::ModelInfo> invalid_model_info_ =
optimization_guide::TestModelInfoBuilder()
.SetModelFilePath(source_root_dir.AppendASCII("chrome")
.AppendASCII("test")
.AppendASCII("data")
.AppendASCII("companion_visual_search")
.AppendASCII("wack-a-doodle.tflite"))
.SetVersion(123)
.Build();

VisualSearchSuggestionsService::ModelUpdateCallback callback =
base::BindOnce([](base::File model, std::string config_proto) {
EXPECT_FALSE(model.IsValid());
EXPECT_TRUE(config_proto.empty());
});
service_->OnModelUpdated(optimization_guide::proto::OptimizationTarget::
OPTIMIZATION_TARGET_VISUAL_SEARCH_CLASSIFICATION,
*invalid_model_info_);
task_environment_.RunUntilIdle();
}

TEST_F(VisualSearchSuggestionsServiceTest, OnModelUpdated_ModelAlreadyLoaded) {
VisualSearchSuggestionsService::ModelUpdateCallback callback =
base::BindOnce([](base::File model, std::string config_proto) {
EXPECT_TRUE(model.IsValid());
EXPECT_TRUE(config_proto.empty());
});
service_->OnModelUpdated(optimization_guide::proto::OptimizationTarget::
OPTIMIZATION_TARGET_VISUAL_SEARCH_CLASSIFICATION,
*model_info_);
// Call OnModelUpdated again to instrument closing the model file before
// reload.
service_->OnModelUpdated(optimization_guide::proto::OptimizationTarget::
OPTIMIZATION_TARGET_VISUAL_SEARCH_CLASSIFICATION,
*model_info_);
task_environment_.RunUntilIdle();
}

0 comments on commit 2350552

Please sign in to comment.