Skip to content

Commit

Permalink
[Merge-M110] [CrOS] MediaApp: Fix web share failures.
Browse files Browse the repository at this point in the history
Starting on M110, third-party iframes need to use `allow: web-share` to
be able to use web share inside the iframe. Add that to the Gallery /
MediaApp iframe to fix being able to use web share in M110.

(cherry picked from commit 31a299f)

Bug: b/265748512
Change-Id: I7fd1c30e622dc7a96497d4ce27bba09fedead2bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4220773
Commit-Queue: Patti Lor <patricialor@chromium.org>
Reviewed-by: Callistus Tan <callistus@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1100816}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4220919
Auto-Submit: Patti Lor <patricialor@chromium.org>
Commit-Queue: Callistus Tan <callistus@google.com>
Cr-Commit-Position: refs/branch-heads/5481@{#984}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
  • Loading branch information
plorcupine authored and Chromium LUCI CQ committed Feb 6, 2023
1 parent a054ce8 commit 23943fe
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion ash/webui/media_app_ui/resources/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@
</style>
<script src="chrome://resources/mojo/mojo/public/js/mojo_bindings_lite.js"></script>
<script src="/first_message_received.js"></script>
<iframe src="chrome-untrusted://media-app/app.html" allow="fullscreen; cross-origin-isolated;"></iframe>
<iframe src="chrome-untrusted://media-app/app.html" allow="fullscreen; cross-origin-isolated; web-share;"></iframe>
<script src="/launch.js" type="module"></script>
</html>
2 changes: 1 addition & 1 deletion ash/webui/media_app_ui/resources/index_dark_light.html
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@
</style>
<script src="chrome://resources/mojo/mojo/public/js/mojo_bindings_lite.js"></script>
<script src="/first_message_received.js"></script>
<iframe src="chrome-untrusted://media-app/app.html" allow="fullscreen; cross-origin-isolated;"></iframe>
<iframe src="chrome-untrusted://media-app/app.html" allow="fullscreen; cross-origin-isolated; web-share;"></iframe>
<script src="/launch.js" type="module"></script>
</html>

0 comments on commit 23943fe

Please sign in to comment.