-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Merge to M85] [XProto] Remove usage of XRRUpdateConfiguration and XR…
…andR ** THIS IS NOT A 100% CLEAN MERGE ** > Since we never initialize the libxrandr (by calling XRRQueryVersion), > Xlib cannot decode the incoming randr notify events. This causes a > crash in XRRUpdateConfiguration. > > This CL solves the issue by removing all calls to > XRRUpdateConfiguration, which updates the XDisplay screen dimensions. > This data is only used in the following APIs: > > XDisplayWidth > XDisplayHeight > XDisplayCells > XDisplayWidthMM > XDisplayHeightMM > XWidthOfScreen > XHeightOfScreen > XWidthMMOfScreen > XHeightMMOfScreen > DisplayWidth > DisplayHeight > DisplayCells > DisplayWidthMM > DisplayHeightMM > WidthOfScreen > HeightOfScreen > WidthMMOfScreen > HeightMMOfScreen > > Therefore, this CL also adds a PRESUBMIT check to ensure they aren't > being used. > > Since this is the last usage of libxrandr, the build config for it is > removed. > > R=nickdiego,sky > > Bug: 1102059 > Change-Id: Ib60811259ae23ffa8af9c50e0bb3d4ac2158e5af > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285068 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Nick Yamane <nickdiego@igalia.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786148} TBR=nickdiego,sky NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Bug: 1102059 Change-Id: I88b35474ac62ca425774201a5907966e5b766b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295825 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/branch-heads/4183@{#476} Cr-Branched-From: 740e9e8-refs/heads/master@{#782793}
- Loading branch information
1 parent
294e62e
commit 24a222b
Showing
9 changed files
with
74 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters