Skip to content

Commit

Permalink
[iOS] Remove tab grid showcase
Browse files Browse the repository at this point in the history
This showcase is crashing, as it is not tested, the investigation to
understand when it is been introduce is impossible. No alert been raised
about the fact that tab grid showcase did not work, so it looks like
nobody use it. This CL removes tab grid showcase.

Change-Id: I2c1a40f80993db9bf0f5bcf04ee221711a3dcde8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4952175
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Aliona Dangla <alionadangla@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1211484}
  • Loading branch information
adangla authored and Chromium LUCI CQ committed Oct 18, 2023
1 parent 38285c4 commit 24f9de2
Show file tree
Hide file tree
Showing 14 changed files with 0 additions and 463 deletions.
1 change: 0 additions & 1 deletion ios/showcase/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ group("features") {
"//ios/showcase/omnibox_popup",
"//ios/showcase/recent_tabs",
"//ios/showcase/settings",
"//ios/showcase/tab_grid",
"//ios/showcase/text_badge_view",
"//ios/showcase/uikit_table_view_cell",
"//ios/showcase/user_policy_prompt",
Expand Down
26 changes: 0 additions & 26 deletions ios/showcase/core/showcase_model.mm
Original file line number Diff line number Diff line change
Expand Up @@ -98,32 +98,6 @@ @implementation ShowcaseModel
showcase::kClassForInstantiationKey : @"SCBubbleCoordinator",
showcase::kUseCaseKey : @"Bubble",
},
@{
showcase::kClassForDisplayKey : @"GridViewController",
showcase::kClassForInstantiationKey : @"SCGridCoordinator",
showcase::kUseCaseKey : @"Grid UI",
},
@{
showcase::kClassForDisplayKey : @"GridCell",
showcase::kClassForInstantiationKey : @"SCGridCellViewController",
showcase::kUseCaseKey : @"Grid cells",
},
@{
showcase::kClassForDisplayKey : @"TabGridViewController",
showcase::kClassForInstantiationKey : @"SCTabGridCoordinator",
showcase::kUseCaseKey : @"Full tab grid UI",
},
@{
showcase::
kClassForDisplayKey : @"TabGridTopToolbar, TabGridBottomToolbar",
showcase::kClassForInstantiationKey : @"SCToolbarsViewController",
showcase::kUseCaseKey : @"Toolbars for tab grid",
},
@{
showcase::kClassForDisplayKey : @"TopAlignedImageView",
showcase::kClassForInstantiationKey : @"SCImageViewController",
showcase::kUseCaseKey : @"ImageView with top aligned aspect fill",
},
@{
showcase::kClassForDisplayKey : @"RecentTabsTableViewController",
showcase::kClassForInstantiationKey : @"SCDarkThemeRecentTabsCoordinator",
Expand Down
30 changes: 0 additions & 30 deletions ios/showcase/tab_grid/BUILD.gn

This file was deleted.

1 change: 0 additions & 1 deletion ios/showcase/tab_grid/OWNERS

This file was deleted.

13 changes: 0 additions & 13 deletions ios/showcase/tab_grid/sc_grid_cell_view_controller.h

This file was deleted.

92 changes: 0 additions & 92 deletions ios/showcase/tab_grid/sc_grid_cell_view_controller.mm

This file was deleted.

13 changes: 0 additions & 13 deletions ios/showcase/tab_grid/sc_grid_coordinator.h

This file was deleted.

69 changes: 0 additions & 69 deletions ios/showcase/tab_grid/sc_grid_coordinator.mm

This file was deleted.

13 changes: 0 additions & 13 deletions ios/showcase/tab_grid/sc_image_view_controller.h

This file was deleted.

63 changes: 0 additions & 63 deletions ios/showcase/tab_grid/sc_image_view_controller.mm

This file was deleted.

13 changes: 0 additions & 13 deletions ios/showcase/tab_grid/sc_tab_grid_coordinator.h

This file was deleted.

0 comments on commit 24f9de2

Please sign in to comment.