Skip to content

Commit

Permalink
Remove forwarding of RenderView messages to RenderWidget.
Browse files Browse the repository at this point in the history
This was already effectively disabled, but retained as a CHECK() to
ensure it wasn't happening in the wild. It doesn't appear to be, so
remove it altogether.

Bug: 990607
Change-Id: I8635aa233771395eb57e7ecc67b0cd4bd5686feb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747155
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685846}
  • Loading branch information
zetafunction authored and Commit Bot committed Aug 10, 2019
1 parent 5cc61f3 commit 26785f9
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 15 deletions.
13 changes: 0 additions & 13 deletions content/renderer/render_view_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1302,10 +1302,6 @@ bool RenderViewImpl::OnMessageReceived(const IPC::Message& message) {

// Adding a new message? Add platform independent ones first, then put the
// platform specific ones at the end.

// Have the widget handle all other messages.
// TODO(ajwong): Remove this cross-object dispatch.
IPC_MESSAGE_UNHANDLED(handled = ForwardToWidgetAndCheckIfHandled(message))
IPC_END_MESSAGE_MAP()

return handled;
Expand Down Expand Up @@ -2273,13 +2269,4 @@ RenderViewImpl::GetCleanupTaskRunner() {
->CleanupTaskRunner();
}

bool RenderViewImpl::ForwardToWidgetAndCheckIfHandled(
const IPC::Message& message) {
// TODO(https://crbug.com/990607): This CHECK is temporary and will be
// removed, assuming nothing crashes in the wild.
bool handled = GetWidget()->OnMessageReceived(message);
CHECK(!handled);
return handled;
}

} // namespace content
2 changes: 0 additions & 2 deletions content/renderer/render_view_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -516,8 +516,6 @@ class CONTENT_EXPORT RenderViewImpl : public blink::WebViewClient,
void UpdateThemePrefs() {}
#endif

bool ForwardToWidgetAndCheckIfHandled(const IPC::Message& message);

// ---------------------------------------------------------------------------
// ADDING NEW FUNCTIONS? Please keep private functions alphabetized and put
// it in the same order in the .cc file as it was in the header.
Expand Down

0 comments on commit 26785f9

Please sign in to comment.