Skip to content

Commit

Permalink
[Extensions] Disable the SW version of a flaky Management API test.
Browse files Browse the repository at this point in the history
ManagementApiNonPersistentApiTest.UninstallViaBrowserAction is only
flaky when run using a service worker. However, the test is currently
disabled for both configurations. This CL reenables the event page
version of the test and updates the TODO with the tracking bug.

(cherry picked from commit 91c0c3d)

Bug: 1449383, 1446968
Change-Id: Idc7de4a9c08796236cb1b4de299f9a2ccd157dc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599023
Commit-Queue: Emilia Paz <emiliapaz@chromium.org>
Auto-Submit: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Emilia Paz <emiliapaz@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1155238}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608733
Owners-Override: Robert Liao <robliao@google.com>
Auto-Submit: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/branch-heads/5790@{#664}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
  • Loading branch information
David Bertoni authored and Chromium LUCI CQ committed Jun 13, 2023
1 parent 6f02fc7 commit 27ca079
Showing 1 changed file with 8 additions and 2 deletions.
Expand Up @@ -82,8 +82,14 @@ IN_PROC_BROWSER_TEST_P(ManagementApiNonPersistentApiTest, UninstallSelf) {

// Tests chrome.management.uninstall with a real user gesture
// (i.e. browserAction.onClicked event).
IN_PROC_BROWSER_TEST_P(ManagementApiNonPersistentApiTest,
UninstallViaBrowserAction) {
// TODO(https://crbug.com/1446968): The service worker version is flaky.
using ManagementApiEventPageTest = ManagementApiNonPersistentApiTest;

INSTANTIATE_TEST_SUITE_P(EventPage,
ManagementApiEventPageTest,
::testing::Values(ContextType::kEventPage));

IN_PROC_BROWSER_TEST_P(ManagementApiEventPageTest, UninstallViaBrowserAction) {
const Extension* extension_b = LoadExtension(test_data_dir_.AppendASCII(
"management/uninstall_via_browser_action/extension_b"));
ASSERT_TRUE(extension_b);
Expand Down

0 comments on commit 27ca079

Please sign in to comment.