Skip to content

Commit

Permalink
WebMediaPlayer::GetVideoSurfaceLayerMode: remove unused method.
Browse files Browse the repository at this point in the history
Bug: 1157671
Change-Id: Ia99b7f452b5a074e289265391c24384f204a300a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3627490
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Markus Handell <handellm@google.com>
Cr-Commit-Position: refs/heads/main@{#1001015}
  • Loading branch information
handellm authored and Chromium LUCI CQ committed May 9, 2022
1 parent a64fcb4 commit 2a057e0
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 29 deletions.
2 changes: 0 additions & 2 deletions third_party/blink/public/platform/web_media_player.h
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,6 @@ class WebMediaPlayer {
virtual NetworkState GetNetworkState() const = 0;
virtual ReadyState GetReadyState() const = 0;

virtual SurfaceLayerMode GetVideoSurfaceLayerMode() const = 0;

// Returns an implementation-specific human readable error message, or an
// empty string if no message is available. The message should begin with a
// UA-specific-error-code (without any ':'), optionally followed by ': ' and
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,6 @@ class BLINK_MODULES_EXPORT WebMediaPlayerMS
WebMediaPlayer::NetworkState GetNetworkState() const override;
WebMediaPlayer::ReadyState GetReadyState() const override;

WebMediaPlayer::SurfaceLayerMode GetVideoSurfaceLayerMode() const override;

WebString GetErrorMessage() const override;
bool DidLoadingProgress() override;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@ class MockWebMediaPlayerForContextMenu : public EmptyWebMediaPlayer {
MOCK_CONST_METHOD0(Duration, double());
MOCK_CONST_METHOD0(HasAudio, bool());
MOCK_CONST_METHOD0(HasVideo, bool());

SurfaceLayerMode GetVideoSurfaceLayerMode() const override {
return SurfaceLayerMode::kAlways;
}
};

class TestWebFrameClientImpl : public frame_test_helpers::TestWebFrameClient {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,6 @@ class MockWebMediaPlayerForImpl : public EmptyWebMediaPlayer {
WebTimeRanges Seekable() const override { return seekable_; }
bool HasVideo() const override { return true; }
bool HasAudio() const override { return has_audio_; }
SurfaceLayerMode GetVideoSurfaceLayerMode() const override {
return SurfaceLayerMode::kAlways;
}

bool has_audio_ = false;
WebTimeRanges seekable_;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,6 @@ class MockWebMediaPlayer : public WebMediaPlayer {
bool IsEnded() const override { return false; }
NetworkState GetNetworkState() const override { return kNetworkStateEmpty; }
ReadyState GetReadyState() const override { return kReadyStateHaveNothing; }
SurfaceLayerMode GetVideoSurfaceLayerMode() const override {
return SurfaceLayerMode::kNever;
}
WebString GetErrorMessage() const override { return WebString(); }

bool DidLoadingProgress() override { return true; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -995,11 +995,6 @@ WebMediaPlayer::ReadyState WebMediaPlayerMS::GetReadyState() const {
return ready_state_;
}

WebMediaPlayer::SurfaceLayerMode WebMediaPlayerMS::GetVideoSurfaceLayerMode()
const {
return surface_layer_mode_;
}

WebString WebMediaPlayerMS::GetErrorMessage() const {
return WebString::FromUTF8(media_log_->GetErrorMessage());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1359,11 +1359,6 @@ WebMediaPlayer::ReadyState WebMediaPlayerImpl::GetReadyState() const {
return ready_state_;
}

WebMediaPlayer::SurfaceLayerMode WebMediaPlayerImpl::GetVideoSurfaceLayerMode()
const {
return surface_layer_mode_;
}

WebString WebMediaPlayerImpl::GetErrorMessage() const {
DCHECK(main_task_runner_->BelongsToCurrentThread());
return WebString::FromUTF8(media_log_->GetErrorMessage());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,6 @@ class PLATFORM_EXPORT WebMediaPlayerImpl
WebMediaPlayer::NetworkState GetNetworkState() const override;
WebMediaPlayer::ReadyState GetReadyState() const override;

WebMediaPlayer::SurfaceLayerMode GetVideoSurfaceLayerMode() const override;

WebString GetErrorMessage() const override;
bool DidLoadingProgress() override;
bool WouldTaintOrigin() const override;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@ class EmptyWebMediaPlayer : public WebMediaPlayer,
void SetPreservesPitch(bool) override {}
void SetWasPlayedWithUserActivation(bool) override {}
void OnRequestPictureInPicture() override {}
SurfaceLayerMode GetVideoSurfaceLayerMode() const override {
return SurfaceLayerMode::kNever;
}
WebTimeRanges Buffered() const override;
WebTimeRanges Seekable() const override;
bool SetSinkId(const WebString& sink_id,
Expand Down

0 comments on commit 2a057e0

Please sign in to comment.