Skip to content

Commit

Permalink
[Launcher] Remove obsolete ranking feature flags.
Browse files Browse the repository at this point in the history
Test: existing
Bug: 1378866
Change-Id: I26757f4e9d74f1e04234c214a8387a71f70792be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4016040
Commit-Queue: Amanda Deacon <amandadeacon@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1068992}
  • Loading branch information
Amanda Deacon authored and Chromium LUCI CQ committed Nov 9, 2022
1 parent 308ca1b commit 2b1435e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 48 deletions.
29 changes: 0 additions & 29 deletions ash/public/cpp/app_list/app_list_features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,6 @@

namespace app_list_features {

BASE_FEATURE(kEnableAppRanker,
"EnableAppRanker",
base::FEATURE_ENABLED_BY_DEFAULT);
BASE_FEATURE(kEnableZeroStateAppsRanker,
"EnableZeroStateAppsRanker",
base::FEATURE_ENABLED_BY_DEFAULT);
BASE_FEATURE(kEnableZeroStateMixedTypesRanker,
"EnableZeroStateMixedTypesRanker",
base::FEATURE_ENABLED_BY_DEFAULT);
BASE_FEATURE(kEnableAppReinstallZeroState,
"EnableAppReinstallZeroState",
base::FEATURE_DISABLED_BY_DEFAULT);
Expand Down Expand Up @@ -51,18 +42,6 @@ BASE_FEATURE(kAnimateScaleOnTabletModeTransition,
"AnimateScaleOnTabletModeTransition",
base::FEATURE_ENABLED_BY_DEFAULT);

bool IsAppRankerEnabled() {
return base::FeatureList::IsEnabled(kEnableAppRanker);
}

bool IsZeroStateAppsRankerEnabled() {
return base::FeatureList::IsEnabled(kEnableZeroStateAppsRanker);
}

bool IsZeroStateMixedTypesRankerEnabled() {
return base::FeatureList::IsEnabled(kEnableZeroStateMixedTypesRanker);
}

bool IsAppReinstallZeroStateEnabled() {
return base::FeatureList::IsEnabled(kEnableAppReinstallZeroState);
}
Expand All @@ -71,14 +50,6 @@ bool IsExactMatchForNonLatinLocaleEnabled() {
return base::FeatureList::IsEnabled(kEnableExactMatchForNonLatinLocale);
}

std::string AppSearchResultRankerPredictorName() {
const std::string predictor_name = base::GetFieldTrialParamValueByFeature(
kEnableZeroStateAppsRanker, "app_search_result_ranker_predictor_name");
if (!predictor_name.empty())
return predictor_name;
return std::string("MrfuAppLaunchPredictor");
}

bool IsAppListLaunchRecordingEnabled() {
return base::FeatureList::IsEnabled(kEnableAppListLaunchRecording);
}
Expand Down
19 changes: 0 additions & 19 deletions ash/public/cpp/app_list/app_list_features.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
#ifndef ASH_PUBLIC_CPP_APP_LIST_APP_LIST_FEATURES_H_
#define ASH_PUBLIC_CPP_APP_LIST_APP_LIST_FEATURES_H_

#include <string>

#include "ash/public/cpp/ash_public_export.h"
#include "base/feature_list.h"
#include "base/time/time.h"
Expand All @@ -16,18 +14,6 @@ namespace app_list_features {
// Please keep these features sorted.
// TODO(newcomer|weidongg): Sort these features.

// Enable app ranking models.
ASH_PUBLIC_EXPORT BASE_DECLARE_FEATURE(kEnableAppRanker);

// Enable a model that ranks zero-state apps search result.
// TODO(crbug.com/989350): This flag can be removed once the
// AppSearchResultRanker is removed. Same with the
// AppSearchResultRankerPredictorName.
ASH_PUBLIC_EXPORT BASE_DECLARE_FEATURE(kEnableZeroStateAppsRanker);

// Enable a model that ranks zero-state files and recent queries.
ASH_PUBLIC_EXPORT BASE_DECLARE_FEATURE(kEnableZeroStateMixedTypesRanker);

// Enables the feature to include a single reinstallation candidate in
// zero-state.
ASH_PUBLIC_EXPORT BASE_DECLARE_FEATURE(kEnableAppReinstallZeroState);
Expand Down Expand Up @@ -64,9 +50,6 @@ ASH_PUBLIC_EXPORT BASE_DECLARE_FEATURE(kLauncherPlayStoreSearch);
// instead of slide up/down).
ASH_PUBLIC_EXPORT BASE_DECLARE_FEATURE(kAnimateScaleOnTabletModeTransition);

ASH_PUBLIC_EXPORT bool IsAppRankerEnabled();
ASH_PUBLIC_EXPORT bool IsZeroStateAppsRankerEnabled();
ASH_PUBLIC_EXPORT bool IsZeroStateMixedTypesRankerEnabled();
ASH_PUBLIC_EXPORT bool IsAppReinstallZeroStateEnabled();
ASH_PUBLIC_EXPORT bool IsAppListLaunchRecordingEnabled();
ASH_PUBLIC_EXPORT bool IsExactMatchForNonLatinLocaleEnabled();
Expand All @@ -81,8 +64,6 @@ ASH_PUBLIC_EXPORT bool IsCompactBubbleLauncherEnabled();
ASH_PUBLIC_EXPORT bool IsLauncherPlayStoreSearchEnabled();
ASH_PUBLIC_EXPORT bool IsAnimateScaleOnTabletModeTransitionEnabled();

ASH_PUBLIC_EXPORT std::string AppSearchResultRankerPredictorName();

} // namespace app_list_features

#endif // ASH_PUBLIC_CPP_APP_LIST_APP_LIST_FEATURES_H_

0 comments on commit 2b1435e

Please sign in to comment.