Skip to content

Commit

Permalink
[ChromeOS] Cargo cult crrev.com/556704 into VideoPlayerBrowserTest
Browse files Browse the repository at this point in the history
Again, PulseAudio layer is unsupported in a target_os="chromeos" build
and VideoPlayerBrowserTest produce LOG errors about that. Again, use a
fake audio layer to eliminate it, cargo cult crrev.com/556704.

Good enough until a future CL provides a more general fix, but step #1
is to kick the VideoPlayerBrowserTest's tyres on the bots.

Bug: 835626,835742,835642
Change-Id: I58cc1c188e95d39f8e75230a761e7b69ff99cabb
Reviewed-on: https://chromium-review.googlesource.com/1049768
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557023}
  • Loading branch information
Noel Gordon authored and Commit Bot committed May 9, 2018
1 parent 248232c commit 2c490c9
Showing 1 changed file with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,22 @@
#include "chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h"

#include "chromeos/chromeos_switches.h"
#include "media/base/media_switches.h"

namespace file_manager {

static constexpr bool kUseFakeAudioLayer = true;

template <GuestMode MODE>
class VideoPlayerBrowserTestBase : public FileManagerBrowserTestBase {
public:
void SetUpCommandLine(base::CommandLine* command_line) override {
if (kUseFakeAudioLayer)
command_line->AppendSwitch(switches::kDisableAudioOutput);

command_line->AppendSwitch(
chromeos::switches::kEnableVideoPlayerChromecastSupport);

FileManagerBrowserTestBase::SetUpCommandLine(command_line);
}

Expand Down

0 comments on commit 2c490c9

Please sign in to comment.