Skip to content

Commit

Permalink
preload: Add LINT.Change to check new prerender trigger types
Browse files Browse the repository at this point in the history
This CL adds LINT.Change and a document link to prerender_utils.cc
about how to include the newly added prerender trigger types in metrics.

Bug: 1462832
Change-Id: I870bf8a4bddf8091410387b97ff42465b7b97343
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4795933
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Huanpo Lin <robertlin@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1188740}
  • Loading branch information
HuanPo Lin authored and Chromium LUCI CQ committed Aug 27, 2023
1 parent 8cca075 commit 2cca886
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
5 changes: 5 additions & 0 deletions chrome/browser/preloading/prerender/prerender_utils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,15 @@ BASE_FEATURE(kHidePrefetchParameter,
"HidePrefetchParameter",
base::FEATURE_ENABLED_BY_DEFAULT);

// If you add a new type of prerender trigger, please refer to the internal
// document go/update-prerender-new-trigger-metrics to make sure that metrics
// include the newly added trigger type.
// LINT.IfChange
const char kDefaultSearchEngineMetricSuffix[] = "DefaultSearchEngine";
const char kDirectUrlInputMetricSuffix[] = "DirectURLInput";
const char kBookmarkBarMetricSuffix[] = "BookmarkBar";
const char kNewTabPageMetricSuffix[] = "NewTabPage";
// LINT.ThenChange()

bool IsDirectUrlInputPrerenderEnabled() {
return base::FeatureList::IsEnabled(features::kOmniboxTriggerForPrerender2);
Expand Down
6 changes: 6 additions & 0 deletions content/public/browser/prerender_trigger_type.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@

namespace content {

// If you add a new type of prerender trigger, please refer to the internal
// document go/update-prerender-new-trigger-metrics to make sure that metrics
// include the newly added trigger type. The string for the trigger type is
// generated in PrerenderPageLoadMetricsObserver::AppendSuffix.
// LINT.IfChange
enum class PrerenderTriggerType {
// https://wicg.github.io/nav-speculation/prerendering.html#speculation-rules
kSpeculationRule,
Expand All @@ -15,6 +20,7 @@ enum class PrerenderTriggerType {
// Trigger used by content embedders.
kEmbedder,
};
// LINT.ThenChange(//components/page_load_metrics/browser/observers/prerender_page_load_metrics_observer.cc)

} // namespace content

Expand Down

0 comments on commit 2cca886

Please sign in to comment.