Skip to content

Commit

Permalink
Revert "Rewrite some aura touch selection browser tests."
Browse files Browse the repository at this point in the history
This reverts commit 5177e73.

Reason for revert: Suspected to be causing failures of TouchSelectionControllerClientAuraCAPFeatureTest.SwipeToMoveCursorMagnifier on the CQ.

Sample failures:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/134124/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-bfcache-rel/50087/overview

Original change's description:
> Rewrite some aura touch selection browser tests.
>
> Try to better test end to end functionality and also clean things up a
> bit. Mainly:
>
> 1. Use ui::test::EventGenerator instead of directly creating the touch
>    and gesture events and calling rwhva->OnTouchEvent/OnGestureEvent.
>
> 2. Check selection bound values rather than just checking that they are
>    non-zero.
>
> 3. Split menu and magnifier test from the handle coordinates test.
>
> Bug: b:295261171
> Change-Id: Id02a40cdee53858910a5aad78fea0138e88c5e47
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4773898
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Commit-Queue: Michelle Chen <michellegc@google.com>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1184654}

Bug: b:295261171
Change-Id: I4fde0964876750cd0ef738ba23e7eb33996a2c20
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4789459
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1184903}
  • Loading branch information
Alex Moshchuk authored and Chromium LUCI CQ committed Aug 17, 2023
1 parent f57673f commit 2ff7bb8
Show file tree
Hide file tree
Showing 3 changed files with 243 additions and 323 deletions.

0 comments on commit 2ff7bb8

Please sign in to comment.