Remove single domain cluster finalizer

This also removes additional field trials that are defunct Change-Id: I6b78c64de875df2d52503df3e09c30a0b930dfde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4039104 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Auto-Submit: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1073680}
chromium · Nov 19, 2022 · 318ebe0 · 318ebe0
1 parent 06fcef6
commit 318ebe0
Show file tree

Hide file tree

Showing 8 changed files with 0 additions and 269 deletions.
diff --git a/components/history_clusters/core/BUILD.gn b/components/history_clusters/core/BUILD.gn
@@ -66,8 +66,6 @@ static_library("core") {
     "similar_visit.h",
     "similar_visit_deduper_cluster_finalizer.cc",
     "similar_visit_deduper_cluster_finalizer.h",
-    "single_domain_cluster_finalizer.cc",
-    "single_domain_cluster_finalizer.h",
     "single_visit_cluster_finalizer.cc",
     "single_visit_cluster_finalizer.h",
     "url_constants.cc",
@@ -116,7 +114,6 @@ source_set("unit_tests") {
     "query_clusters_state_unittest.cc",
     "ranking_cluster_finalizer_unittest.cc",
     "similar_visit_deduper_cluster_finalizer_unittest.cc",
-    "single_domain_cluster_finalizer_unittest.cc",
     "single_visit_cluster_finalizer_unittest.cc",
   ]
   deps = [

diff --git a/components/history_clusters/core/config.cc b/components/history_clusters/core/config.cc
@@ -254,12 +254,6 @@ Config::Config() {
             "hide_single_visit_clusters_on_prominent_ui_surfaces",
             should_hide_single_visit_clusters_on_prominent_ui_surfaces);
 
-    should_hide_single_domain_clusters_on_prominent_ui_surfaces =
-        GetFieldTrialParamByFeatureAsBool(
-            features::kOnDeviceClustering,
-            "hide_single_domain_clusters_on_prominent_ui_surfaces",
-            should_hide_single_domain_clusters_on_prominent_ui_surfaces);
-
     should_filter_noisy_clusters = GetFieldTrialParamByFeatureAsBool(
         features::kOnDeviceClustering, "filter_noisy_clusters",
         should_filter_noisy_clusters);

diff --git a/components/history_clusters/core/config.h b/components/history_clusters/core/config.h
@@ -245,10 +245,6 @@ struct Config {
   // Whether to hide single-visit clusters on prominent UI surfaces.
   bool should_hide_single_visit_clusters_on_prominent_ui_surfaces = true;
 
-  // Whether to hide clusters that only contain URLs from the same domain on
-  // prominent UI surfaces.
-  bool should_hide_single_domain_clusters_on_prominent_ui_surfaces = false;
-
   // Whether to filter clusters that are noisy from the UI. This will
   // heuristically remove clusters that are unlikely to be "interesting".
   bool should_filter_noisy_clusters = true;

diff --git a/components/history_clusters/core/on_device_clustering_backend.cc b/components/history_clusters/core/on_device_clustering_backend.cc
@@ -32,7 +32,6 @@
 #include "components/history_clusters/core/on_device_clustering_util.h"
 #include "components/history_clusters/core/ranking_cluster_finalizer.h"
 #include "components/history_clusters/core/similar_visit_deduper_cluster_finalizer.h"
-#include "components/history_clusters/core/single_domain_cluster_finalizer.h"
 #include "components/history_clusters/core/single_visit_cluster_finalizer.h"
 #include "components/optimization_guide/core/batch_entity_metadata_task.h"
 #include "components/optimization_guide/core/entity_metadata_provider.h"
@@ -358,10 +357,6 @@ OnDeviceClusteringBackend::ClusterVisitsOnBackgroundThread(
     cluster_finalizers.push_back(
         std::make_unique<SingleVisitClusterFinalizer>());
   }
-  if (GetConfig().should_hide_single_domain_clusters_on_prominent_ui_surfaces) {
-    cluster_finalizers.push_back(
-        std::make_unique<SingleDomainClusterFinalizer>());
-  }
   // Add feature to turn on/off site engagement score filter.
   if (engagement_score_provider_is_valid &&
       GetConfig().should_filter_noisy_clusters) {

diff --git a/components/history_clusters/core/single_domain_cluster_finalizer.cc b/components/history_clusters/core/single_domain_cluster_finalizer.cc
diff --git a/components/history_clusters/core/single_domain_cluster_finalizer.h b/components/history_clusters/core/single_domain_cluster_finalizer.h
diff --git a/components/history_clusters/core/single_domain_cluster_finalizer_unittest.cc b/components/history_clusters/core/single_domain_cluster_finalizer_unittest.cc
diff --git a/testing/variations/fieldtrial_testing_config.json b/testing/variations/fieldtrial_testing_config.json
@@ -6226,80 +6226,6 @@
             ]
         }
     ],
-    "JourneysArPlRuZh": [
-        {
-            "platforms": [
-                "chromeos",
-                "chromeos_lacros",
-                "fuchsia",
-                "linux",
-                "mac",
-                "windows"
-            ],
-            "experiments": [
-                {
-                    "name": "Enabled_20220502",
-                    "params": {
-                        "JourneysLocaleOrLanguageAllowlist": "de,en,en-AU,en-CA,en-GB,en-US,es,fr,it,nl,pt,tr,ar,pl,ru,zh",
-                        "supported_locales": "de,en,en-AU,en-CA,en-GB,en-US,es,fr,it,nl,pt,tr,ar,pl,ru,zh"
-                    },
-                    "enable_features": [
-                        "Journeys",
-                        "PageEntitiesPageContentAnnotations"
-                    ]
-                }
-            ]
-        }
-    ],
-    "JourneysHaTSSurvey": [
-        {
-            "platforms": [
-                "chromeos",
-                "chromeos_lacros",
-                "fuchsia",
-                "linux",
-                "mac",
-                "windows"
-            ],
-            "experiments": [
-                {
-                    "name": "EnabledOmniboxEntrypoint",
-                    "params": {
-                        "en_site_id": "5GjwX6M8T0ugnJ3q1cK0SahkU1Bm",
-                        "probability": "1.0",
-                        "survey": "journeys-omnibox-entrypoint",
-                        "survey-delay-duration": "6s"
-                    },
-                    "enable_features": [
-                        "JourneysSurveyForOmniboxEntrypoint"
-                    ]
-                }
-            ]
-        }
-    ],
-    "JourneysHideSingleDomainClusters": [
-        {
-            "platforms": [
-                "chromeos",
-                "chromeos_lacros",
-                "fuchsia",
-                "linux",
-                "mac",
-                "windows"
-            ],
-            "experiments": [
-                {
-                    "name": "Enabled_20220518",
-                    "params": {
-                        "hide_single_domain_clusters_on_prominent_ui_surfaces": "true"
-                    },
-                    "enable_features": [
-                        "HistoryClustersOnDeviceClustering"
-                    ]
-                }
-            ]
-        }
-    ],
     "JourneysPersistence": [
         {
             "platforms": [
@@ -6321,30 +6247,6 @@
             ]
         }
     ],
-    "JourneysSearchTermsKeywords": [
-        {
-            "platforms": [
-                "fuchsia",
-                "linux",
-                "mac",
-                "windows"
-            ],
-            "experiments": [
-                {
-                    "name": "Enabled_20220912",
-                    "params": {
-                        "keyword_filter_on_categories": "false",
-                        "keyword_filter_on_entity_aliases": "false",
-                        "keyword_filter_on_noisy_visits": "false",
-                        "keyword_filter_on_search_terms": "true"
-                    },
-                    "enable_features": [
-                        "JourneysKeywordFiltering"
-                    ]
-                }
-            ]
-        }
-    ],
     "JourneysSuggestionRow": [
         {
             "platforms": [