Remove expired homepage promo flag entry

The feature code has been cleaned up already, just removing this left
over entry in flag-metadata.json.

Bug: 1068831
Change-Id: I04fac1540fd397b2ed53dc3562c310da77d4996b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3536771
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Auto-Submit: Wenyu Fu <wenyufu@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#985096}

chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

@@ -485,8 +485,6 @@ public void openHelpPage() {
 
         // Record the timestamp at which the new tab page's construction started.
         uma.trackTimeToFirstDraw(mFeedSurfaceProvider.getView(), mConstructedTimeNs);
-
-        TrackerFactory.getTrackerForProfile(profile).notifyEvent(EventConstants.NTP_SHOWN);
     }
 
     /**

chrome/browser/about_flags.cc

@@ -2121,28 +2121,6 @@ const FeatureEntry::FeatureVariation
          std::size(kAutofillUseMobileLabelDisambiguationShowOne), nullptr}};
 #endif  // BUILDFLAG(IS_ANDROID)
 
-#if BUILDFLAG(IS_ANDROID)
-const FeatureEntry::FeatureParam kHomepagePromoCardLarge[] = {
-    {"promo-card-variation", "Large"}};
-const FeatureEntry::FeatureParam kHomepagePromoCardCompact[] = {
-    {"promo-card-variation", "Compact"}};
-const FeatureEntry::FeatureParam kHomepagePromoCardSlim[] = {
-    {"promo-card-variation", "Slim"}};
-const FeatureEntry::FeatureParam kHomepagePromoCardSuppressing[] = {
-    {"promo-card-variation", "Compact"},
-    {"suppressing_sign_in_promo", "true"}};
-
-const FeatureEntry::FeatureVariation kHomepagePromoCardVariations[] = {
-    {"Large", kHomepagePromoCardLarge, std::size(kHomepagePromoCardLarge),
-     nullptr},
-    {"Compact", kHomepagePromoCardCompact, std::size(kHomepagePromoCardCompact),
-     nullptr},
-    {"Slim", kHomepagePromoCardSlim, std::size(kHomepagePromoCardSlim),
-     nullptr},
-    {"Compact_SuppressingSignInPromo", kHomepagePromoCardSuppressing,
-     std::size(kHomepagePromoCardSuppressing), nullptr}};
-#endif  // BUILDFLAG(IS_ANDROID)
-
 #if BUILDFLAG(IS_ANDROID)
 const FeatureEntry::FeatureParam kLensCameraAssistedSearchLensButtonStart[] = {
     {"searchBoxStartVariantForLensCameraAssistedSearch", "true"}};
@@ -6576,14 +6554,6 @@ const FeatureEntry kFeatureEntries[] = {
      FEATURE_VALUE_TYPE(chromeos::features::kCrostiniDiskResizing)},
 #endif  // BUILDFLAG(IS_CHROMEOS_ASH)
 
-#if BUILDFLAG(IS_ANDROID)
-    {"homepage-promo-card", flag_descriptions::kHomepagePromoCardName,
-     flag_descriptions::kHomepagePromoCardDescription, kOsAndroid,
-     FEATURE_WITH_PARAMS_VALUE_TYPE(chrome::android::kHomepagePromoCard,
-                                    kHomepagePromoCardVariations,
-                                    "HomepagePromoAndroid")},
-#endif  // BUILDFLAG(IS_ANDROID)
-
 #if BUILDFLAG(IS_CHROMEOS_ASH)
     {"sync-settings-categorization",
      flag_descriptions::kSyncSettingsCategorizationName,

chrome/browser/flag-metadata.json

@@ -3544,11 +3544,6 @@
     "owners": [ "sophiechang", "chrome-journeys@google.com", "chrome-intelligence-core@google.com" ],
     "expiry_milestone": 105
   },
-  {
-    "name": "homepage-promo-card",
-    "owners": [ "wenyufu", "clank-app-team@google.com" ],
-    "expiry_milestone": 90
-  },
   {
     "name": "http-cache-partitioning",
     "owners": [ "shivanisha" ],

chrome/browser/flag_descriptions.cc

@@ -3209,12 +3209,6 @@ const char kGridTabSwitcherForTabletsName[] = "Grid tab switcher for tablets";
 const char kGridTabSwitcherForTabletsDescription[] =
     "Enable grid tab switcher for tablets, replacing the tab strip.";
 
-const char kHomepagePromoCardName[] =
-    "Enable homepage promo card on the New Tab Page";
-const char kHomepagePromoCardDescription[] =
-    "Enable homepage promo card that will be shown to users with partner "
-    "configured homepage.";
-
 const char kInstanceSwitcherName[] = "Enable instance switcher";
 const char kInstanceSwitcherDescription[] =
     "Enable instance switcher dialog UI that helps users manage multiple "

chrome/browser/flag_descriptions.h

@@ -1824,9 +1824,6 @@ extern const char kFeedStampDescription[];
 extern const char kGridTabSwitcherForTabletsName[];
 extern const char kGridTabSwitcherForTabletsDescription[];
 
-extern const char kHomepagePromoCardName[];
-extern const char kHomepagePromoCardDescription[];
-
 extern const char kInstanceSwitcherName[];
 extern const char kInstanceSwitcherDescription[];
 

chrome/browser/flags/android/chrome_feature_list.cc

@@ -131,7 +131,6 @@ const base::Feature* const kFeaturesExposedToJava[] = {
     &features::kWebNfc,
     &features::kIncognitoNtpRevamp,
     &feature_engagement::kEnableAutomaticSnooze,
-    &feature_engagement::kIPHHomepagePromoCardFeature,
     &feature_engagement::kIPHNewTabPageHomeButtonFeature,
     &feature_engagement::kIPHSnooze,
     &feature_engagement::kIPHTabSwitcherButtonFeature,
@@ -234,7 +233,6 @@ const base::Feature* const kFeaturesExposedToJava[] = {
     &kGoogleLensSdkIntent,
     &kGridTabSwitcherForTablets,
     &kHandleMediaIntents,
-    &kHomepagePromoCard,
     &kImmersiveUiMode,
     &kIncognitoReauthenticationForAndroid,
     &kIncognitoScreenshot,
@@ -641,9 +639,6 @@ const base::Feature kGridTabSwitcherForTablets{
 const base::Feature kHandleMediaIntents{"HandleMediaIntents",
                                         base::FEATURE_ENABLED_BY_DEFAULT};
 
-const base::Feature kHomepagePromoCard{"HomepagePromoCard",
-                                       base::FEATURE_DISABLED_BY_DEFAULT};
-
 const base::Feature kImmersiveUiMode{"ImmersiveUiMode",
                                      base::FEATURE_DISABLED_BY_DEFAULT};
 

chrome/browser/flags/android/chrome_feature_list.h

@@ -98,7 +98,6 @@ extern const base::Feature kFocusOmniboxInIncognitoTabIntents;
 extern const base::Feature kGoogleLensSdkIntent;
 extern const base::Feature kGridTabSwitcherForTablets;
 extern const base::Feature kHandleMediaIntents;
-extern const base::Feature kHomepagePromoCard;
 extern const base::Feature kImmersiveUiMode;
 extern const base::Feature kIncognitoReauthenticationForAndroid;
 extern const base::Feature kIncognitoScreenshot;

chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/ToolbarTabControllerImpl.java

@@ -12,7 +12,6 @@
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.chrome.browser.toolbar.bottom.BottomControlsCoordinator;
 import org.chromium.components.embedder_support.util.UrlConstants;
-import org.chromium.components.embedder_support.util.UrlUtilities;
 import org.chromium.components.feature_engagement.EventConstants;
 import org.chromium.components.feature_engagement.Tracker;
 import org.chromium.components.profile_metrics.BrowserProfileType;
@@ -136,10 +135,6 @@ private void recordHomeButtonUseForIPH(String homepageUrl) {
         if (tab == null || tracker == null) return;
 
         tracker.notifyEvent(EventConstants.HOMEPAGE_BUTTON_CLICKED);
-
-        if (UrlUtilities.isNTPUrl(homepageUrl)) {
-            tracker.notifyEvent(EventConstants.NTP_HOME_BUTTON_CLICKED);
-        }
     }
 
     private void recordHomeButtonUserPerProfileType() {

components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/EventConstants.java

@@ -186,10 +186,6 @@ public final class EventConstants {
     /** 'Manage windows' menu for multi-instance support feature was tapped. */
     public static final String INSTANCE_SWITCHER_IPH_USED = "instance_switcher_iph_used";
 
-    /** HomepagePromo has been accepted. */
-    public static final String NTP_SHOWN = "ntp_shown";
-    public static final String NTP_HOME_BUTTON_CLICKED = "ntp_homebutton_clicked";
-
     public static final String TAB_SWITCHER_BUTTON_CLICKED = "tab_switcher_button_clicked";
 
     public static final String FOREGROUND_SESSION_DESTROYED = "foreground_session_destroyed";

components/feature_engagement/public/feature_constants.cc

@@ -179,8 +179,6 @@ const base::Feature kIPHFeedCardMenuFeature{"IPH_FeedCardMenu",
                                             base::FEATURE_DISABLED_BY_DEFAULT};
 const base::Feature kIPHGenericAlwaysTriggerHelpUiFeature{
     "IPH_GenericAlwaysTriggerHelpUiFeature", base::FEATURE_ENABLED_BY_DEFAULT};
-const base::Feature kIPHHomepagePromoCardFeature{
-    "IPH_HomepagePromoCard", base::FEATURE_DISABLED_BY_DEFAULT};
 const base::Feature kIPHIdentityDiscFeature{"IPH_IdentityDisc",
                                             base::FEATURE_DISABLED_BY_DEFAULT};
 const base::Feature kIPHInstanceSwitcherFeature{

components/feature_engagement/public/feature_constants.h

@@ -112,7 +112,6 @@ extern const base::Feature kIPHFeedCardMenuFeature;
 extern const base::Feature kIPHGenericAlwaysTriggerHelpUiFeature;
 extern const base::Feature kIPHHomePageButtonFeature;
 extern const base::Feature kIPHHomepageTileFeature;
-extern const base::Feature kIPHHomepagePromoCardFeature;
 extern const base::Feature kIPHIdentityDiscFeature;
 extern const base::Feature kIPHInstanceSwitcherFeature;
 extern const base::Feature kIPHKeyboardAccessoryAddressFillingFeature;

components/feature_engagement/public/feature_list.cc

@@ -61,7 +61,6 @@ const base::Feature* const kAllFeatures[] = {
     &kIPHFeatureNotificationGuideVoiceSearchUsedFeature,
     &kIPHFeedCardMenuFeature,
     &kIPHGenericAlwaysTriggerHelpUiFeature,
-    &kIPHHomepagePromoCardFeature,
     &kIPHIdentityDiscFeature,
     &kIPHInstanceSwitcherFeature,
     &kIPHKeyboardAccessoryAddressFillingFeature,

components/feature_engagement/public/feature_list.h

@@ -129,7 +129,6 @@ DEFINE_VARIATION_PARAM(kIPHFeatureNotificationGuideVoiceSearchHelpBubbleFeature,
 DEFINE_VARIATION_PARAM(kIPHFeedCardMenuFeature, "IPH_FeedCardMenu");
 DEFINE_VARIATION_PARAM(kIPHGenericAlwaysTriggerHelpUiFeature,
                        "IPH_GenericAlwaysTriggerHelpUiFeature");
-DEFINE_VARIATION_PARAM(kIPHHomepagePromoCardFeature, "IPH_HomepagePromoCard");
 DEFINE_VARIATION_PARAM(kIPHIdentityDiscFeature, "IPH_IdentityDisc");
 DEFINE_VARIATION_PARAM(kIPHInstanceSwitcherFeature, "IPH_InstanceSwitcher");
 DEFINE_VARIATION_PARAM(kIPHKeyboardAccessoryAddressFillingFeature,
@@ -303,7 +302,6 @@ constexpr flags_ui::FeatureEntry::FeatureVariation
         VARIATION_ENTRY(kIPHDownloadInfoBarDownloadsAreFasterFeature),
         VARIATION_ENTRY(kIPHEphemeralTabFeature),
         VARIATION_ENTRY(kIPHFeedCardMenuFeature),
-        VARIATION_ENTRY(kIPHHomepagePromoCardFeature),
         VARIATION_ENTRY(kIPHIdentityDiscFeature),
         VARIATION_ENTRY(kIPHInstanceSwitcherFeature),
         VARIATION_ENTRY(kIPHKeyboardAccessoryAddressFillingFeature),

testing/buildbot/filters/android.emulator_m.chrome_public_test_apk.filter

@@ -45,9 +45,6 @@
 # crbug.com/1062055
 -org.chromium.chrome.browser.metrics.StartupLoadingMetricsTest.testWebApkStartRecorded
 
-# crbug.com/1077316
--org.chromium.chrome.browser.ntp.cards.promo.HomepagePromoTest.testChangeHomepageAndUndo_*
-
 # crbug.com/1090942
 -org.chromium.chrome.browser.autofill.settings.AutofillPaymentMethodsFragmentTest.*
 

tools/metrics/histograms/enums.xml

@@ -2196,23 +2196,6 @@ Unknown properties are collapsed to zero. -->
   <int value="257" label="GATT_FAILURE"/>
 </enum>
 
-<enum name="AndroidHomepagePromoAction">
-  <int value="0" label="Promo created">
-    The Android Homepage promo was created on the new tab page.
-  </int>
-  <int value="1" label="Promo shown">The Android homepage promo was shown.</int>
-  <int value="2" label="Promo dismissed">
-    User dismissed the homepage promo.
-  </int>
-  <int value="3" label="Promo accepted">
-    User changed their homepage by accepting the promo.
-  </int>
-  <int value="4" label="Promo change undo">
-    User changed their homepage by accepting the promo, but then undid the
-    change through snackbar.
-  </int>
-</enum>
-
 <enum name="AndroidIntentNonSafelistedHeaderNameHashes">
   <int value="4229679564" label="user-agent"/>
 </enum>