Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "[Reland] VT: Fix snapshot rect for a resizing virtual keyboard"
This reverts commit c5d45f4. Reason for revert: Still failing ViewTransitionPixelTest#testVirtualKeyboardResizesContentOld on multiple bots. For details see https://crbug.com/1383541 Original change's description: > [Reland] VT: Fix snapshot rect for a resizing virtual keyboard > > Reland note: original CL in initial upload. Fix is to avoid using > the inset method which was added in a newer API level. > > ViewTransitions compute the "snapshot rect" which is a viewport-like > rect that doesn't change size when UI such as scrollbars, virtual > keyboard, mobile URL bar are showing or hidden. > > When the keyboard is in a resize-content mode (so that innerHeight is > changed by the keyboard, see: > https://developer.chrome.com/blog/viewport-resize-behavior/), the > snapshot rect must account for the keyboard by outsetting the layout > viewport. > > This CL plumbs the virtual-keyboard height into the renderer via > SynchronizeVisualProperties so that DocumentTransitionStyleTracker can > use this value to perform the outset. This value includes any keyboard > accessories such as the autofill bar. > > Since the keyboard resize behavior is implemented in the //chrome layer, > this CL adds end-to-end chrome browser tests for this behavior. This > requires introducing some hand-rolled pixel testing functionality into > java tests which isn't common so also requires plumbing the > InsertVisualStateCallback mechanism into java, allowing tests to wait on > a Blink main frame to be presented to the screen. > > Bug: 1350910 > Change-Id: Ib86da86fbc4f9079fc4eafe26d055cb6d2837a6d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4021408 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Auto-Submit: David Bokan <bokan@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1069983} Bug: 1350910, 1383541 Change-Id: I131d55a4af94a3d7b38bc896092588cde63cd7b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4023983 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Owners-Override: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/main@{#1070607}
- Loading branch information