Skip to content

Commit

Permalink
[ConsentV2] Update dialog button text
Browse files Browse the repository at this point in the history
Screenshot: https://screenshot.googleplex.com/4TVafV64CUNbBaD

(cherry picked from commit 24a6fcc)

Bug: 1318685
Change-Id: I5cd3456a782b0efafb84c44a152c050bc889cf1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652589
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1007680}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3679888
Owners-Override: Prudhvikumar Bommana <pbommana@google.com>
Reviewed-by: Prudhvikumar Bommana <pbommana@google.com>
Cr-Commit-Position: refs/branch-heads/5060@{#434}
Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
  • Loading branch information
Mei Liang authored and Chromium LUCI CQ committed May 31, 2022
1 parent 1af416d commit 3272dfc
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ NtpDiscountConsentDialogView::NtpDiscountConsentDialogView(
SetOwnedByWidget(true);
// TODO(meiliang@): Set text for the button.
SetButtons(ui::DIALOG_BUTTON_CANCEL | ui::DIALOG_BUTTON_OK);
SetButtonLabel(
ui::DIALOG_BUTTON_CANCEL,
l10n_util::GetStringUTF16(IDS_DISCOUNT_CONTEXTUAL_CONSENT_NO_THANKS));
SetButtonLabel(ui::DIALOG_BUTTON_OK,
l10n_util::GetStringUTF16(
IDS_NATIVE_NTP_CART_DISCOUNT_CONSENT_ACCEPT_BUTTON));
set_fixed_width(views::LayoutProvider::Get()->GetDistanceMetric(
DISTANCE_LARGE_MODAL_DIALOG_PREFERRED_WIDTH));

Expand Down
3 changes: 3 additions & 0 deletions components/commerce_strings.grdp
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
<message name="IDS_DISCOUNT_CONTEXTUAL_CONSENT_ACCEPTED_CONFIRMATION_DONE" desc="The text shown on the consent confirmation bubble bubble. User can click this button to close the bubble.">
Done
</message>
<message name="IDS_NATIVE_NTP_CART_DISCOUNT_CONSENT_ACCEPT_BUTTON" translateable="false" desc="Text shown on the accept button of the consent dialog. By clicking this button, users has chosen to accept the consent.">
Yes, I'm in
</message>
<message name="IDS_NATIVE_NTP_CART_DISCOUNT_CONSENT_TITLE" translateable="false" desc="The title shown on the native consent dialog for getting discount. Note: This is intentionally left blank. No translation is required.">
Get discounts on your carts&#13; &amp; when you shop online
</message>
Expand Down

0 comments on commit 3272dfc

Please sign in to comment.