Skip to content

Commit

Permalink
Remove "Save page as Web Bundle" feature (2/4)
Browse files Browse the repository at this point in the history
This removes WebContents::GenerateWebBundle().

Bug: 1409346
Change-Id: I2321bf5c1c5832b2a0d6add87c4ea4a5861af130
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4150623
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1096557}
  • Loading branch information
irori authored and Chromium LUCI CQ committed Jan 25, 2023
1 parent 5fb9701 commit 34ccdb1
Show file tree
Hide file tree
Showing 11 changed files with 0 additions and 621 deletions.
2 changes: 0 additions & 2 deletions content/browser/BUILD.gn
Expand Up @@ -2149,8 +2149,6 @@ source_set("browser") {
"web_package/prefetched_signed_exchange_cache_adapter.h",
"web_package/prefetched_signed_exchange_cache_entry.cc",
"web_package/prefetched_signed_exchange_cache_entry.h",
"web_package/save_as_web_bundle_job.cc",
"web_package/save_as_web_bundle_job.h",
"web_package/signed_exchange_cert_fetcher.cc",
"web_package/signed_exchange_cert_fetcher.h",
"web_package/signed_exchange_cert_fetcher_factory.cc",
Expand Down
10 changes: 0 additions & 10 deletions content/browser/web_contents/web_contents_impl.cc
Expand Up @@ -106,7 +106,6 @@
#include "content/browser/web_contents/java_script_dialog_commit_deferring_condition.h"
#include "content/browser/web_contents/web_contents_view.h"
#include "content/browser/web_contents/web_contents_view_child_frame.h"
#include "content/browser/web_package/save_as_web_bundle_job.h"
#include "content/browser/webui/web_ui_controller_factory_registry.h"
#include "content/browser/webui/web_ui_impl.h"
#include "content/browser/xr/service/xr_runtime_manager_impl.h"
Expand Down Expand Up @@ -5278,15 +5277,6 @@ void WebContentsImpl::GenerateMHTMLWithResult(
std::move(callback));
}

void WebContentsImpl::GenerateWebBundle(
const base::FilePath& file_path,
base::OnceCallback<void(uint64_t /* file_size */,
data_decoder::mojom::WebBundlerError)> callback) {
OPTIONAL_TRACE_EVENT1("content", "WebContentsImpl::GenerateWebBundle",
"file_path", file_path);
SaveAsWebBundleJob::Start(this, file_path, std::move(callback));
}

const std::string& WebContentsImpl::GetContentsMimeType() {
return GetPrimaryPage().contents_mime_type();
}
Expand Down
4 changes: 0 additions & 4 deletions content/browser/web_contents/web_contents_impl.h
Expand Up @@ -486,10 +486,6 @@ class CONTENT_EXPORT WebContentsImpl : public WebContents,
void GenerateMHTMLWithResult(
const MHTMLGenerationParams& params,
MHTMLGenerationResult::GenerateMHTMLCallback callback) override;
void GenerateWebBundle(
const base::FilePath& file_path,
base::OnceCallback<void(uint64_t, data_decoder::mojom::WebBundlerError)>
callback) override;
const std::string& GetContentsMimeType() override;
blink::RendererPreferences* GetMutableRendererPrefs() override;
void Close() override;
Expand Down
106 changes: 0 additions & 106 deletions content/browser/web_package/save_as_web_bundle_job.cc

This file was deleted.

74 changes: 0 additions & 74 deletions content/browser/web_package/save_as_web_bundle_job.h

This file was deleted.

0 comments on commit 34ccdb1

Please sign in to comment.