Skip to content

Commit

Permalink
Add tests to the scroll unification virtual test case
Browse files Browse the repository at this point in the history
We add all failing tests because of enabling scroll unification into the
scroll unification virtual test case, and add them to the test expectation
file.


Bug: 1047176
Change-Id: I47d1c70d6583d10bd08209934110d43f4cf692ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2766362
Reviewed-by: Liviu Tinta <liviutinta@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#867986}
  • Loading branch information
LanWei22 authored and Chromium LUCI CQ committed Mar 31, 2021
1 parent 1c39d24 commit 3617a54
Show file tree
Hide file tree
Showing 12 changed files with 225 additions and 2 deletions.
58 changes: 58 additions & 0 deletions third_party/blink/web_tests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -4918,6 +4918,64 @@ crbug.com/1054577 [ Win ] virtual/storage-access-api/external/wpt/storage-access
crbug.com/1054577 [ Mac ] external/wpt/media-source/mediasource-detach.html [ Pass Failure ]
crbug.com/1054577 [ Mac ] external/wpt/storage-access-api/requestStorageAccess.sub.window.html [ Pass Failure ]

# Failing tests because of enabling scroll unification flag
crbug.com/476553 virtual/scroll-unification/external/wpt/dom/events/scrolling/overscroll-event-fired-to-scrolled-element.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/external/wpt/dom/events/scrolling/scrollend-event-for-user-scroll.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/hit-test-counts.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/middleClickAutoscroll-click-hyperlink.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/middleClickAutoscroll-click.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/middleClickAutoscroll-in-iframe.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/middleClickAutoscroll-nested-divs.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/mouse-cursor-change.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/platform-wheelevent-paging-xy-in-scrolling-div.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/remove-child-onscroll.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/scrollbar-double-click.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/touch/touch-latched-scroll-node-removed.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/touch/gesture/focus-selectionchange-on-tap.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/touch/gesture/gesture-scrollbar.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/touch/gesture/gesture-scrollbar-mainframe.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/touch/gesture/gesture-scrollbar-textarea.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/touch/gesture/gesture-tap-click-common-ancestor.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/touch/gesture/gesture-tap-frame-removed.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/touch/gesture/touch-gesture-scroll-input-field.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/touch/gesture/touch-gesture-scroll-listbox.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/events/wheel/wheel-latched-scroll-node-removed.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/scrolling/autoscroll-latch-clicked-node-if-parent-unscrollable.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/scrolling/resize-corner-tracking-touch.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/fast/scrolling/subpixel-overflow-mouse-drag.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/http/tests/misc/destroy-middle-click-locked-target-crash.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/http/tests/misc/lock-renderer-for-middle-click-autoscroll.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/http/tests/misc/scroll-cross-origin-iframes.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/http/tests/misc/scroll-cross-origin-iframes-scrollbar.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/plugins/gesture-events-scrolled.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/plugins/gesture-events.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/plugins/mouse-click-iframe-to-plugin.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/plugins/transformed-events.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/scrollbars/listbox-scrollbar-combinations.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/scrollbars/scrollbar-added-during-drag.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification/scrollbars/scrollbar-drag-thumb-with-large-content.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-layout_ng_block_frag/fast/forms/fieldset/fieldset-legend-change.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-overlay-scrollbar/plugin-overlay-scrollbar-mouse-capture.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-percent-based-scrolling/fast/scrolling/scrollbars/mouse-autoscrolling-on-deleted-scrollbar.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-percent-based-scrolling/fast/scrolling/scrollbars/mouse-autoscrolling-on-scrollbar.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-prefer_compositing_to_lcd_text/scrollbars/auto-scrollbar-fades-out.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-prefer_compositing_to_lcd_text/scrollbars/basic-scrollbar.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-prefer_compositing_to_lcd_text/scrollbars/disabled-scrollbar.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-prefer_compositing_to_lcd_text/scrollbars/hidden-scrollbars-invisible.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-prefer_compositing_to_lcd_text/scrollbars/listbox-scrollbar-combinations.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-prefer_compositing_to_lcd_text/scrollbars/overlay-scrollbars-within-overflow-scroll.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-prefer_compositing_to_lcd_text/scrollbars/scrollbar-added-during-drag.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-prefer_compositing_to_lcd_text/scrollbars/scrollbar-buttons.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-prefer_compositing_to_lcd_text/scrollbars/scrollbar-corner-colors.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-prefer_compositing_to_lcd_text/scrollbars/scrollbar-drag-thumb-with-large-content.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-prefer_compositing_to_lcd_text/scrollbars/scrollbar-orientation.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-synchronous_html_parser/external/wpt/dom/events/webkit-animation-iteration-event.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-synchronous_html_parser/external/wpt/dom/events/scrolling/scrollend-event-for-user-scroll.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-wheel-event-regions/fast/events/platform-wheelevent-paging-xy-in-scrolling-div.html [ Pass Failure Timeout Crash ]
crbug.com/476553 virtual/scroll-unification-wheel-event-regions/fast/events/wheel/wheel-latched-scroll-node-removed.html [ Pass Failure Timeout Crash ]

# Sheriff 2020-02-07

crbug.com/1050039 [ Mac ] fast/events/onbeforeunload-focused-iframe.html [ Pass Failure ]
Expand Down
81 changes: 79 additions & 2 deletions third_party/blink/web_tests/VirtualTestSuites
Original file line number Diff line number Diff line change
Expand Up @@ -800,12 +800,89 @@
},
{
"prefix": "scroll-unification",
"bases": ["fast/scrolling/scrollbars",
"bases": ["fast/events",
"fast/scrolling",
"fast/scroll-snap",
"fast/forms/select-popup",
"fast/forms/suggestion-picker"],
"fast/forms/suggestion-picker",
"http/tests/misc",
"plugins",
"scrollbars",
"external/wpt/dom/events/scrolling",
"external/wpt/feature-policy/experimental-features",
"external/wpt/permissions-policy/experimental-features",
"external/wpt/pointerevents/pointerevent_iframe-touch-action-none_touch.html",
"external/wpt/touch-events/multi-touch-interactions.html",
"fast/forms/fieldset/overflow-scroll-interaction.html",
"fast/scroll-behavior/middleclick-autoscroll-nested-elements.html",
"fast/scroll-behavior/middleclick-autoscroll-use-count.html",
"http/tests/credentialmanager/credentialscontainer-create-with-virtual-authenticator.html",
"ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm"],
"args": ["--enable-features=ScrollUnification",
"--enable-threaded-compositing"]
},
{
"prefix": "scroll-unification-hidpi",
"bases": ["fast/scrolling/scrollbars/dsf-ready"],
"args": ["--enable-features=ScrollUnification",
"--enable-threaded-compositing",
"--disable-smooth-scrolling",
"--force-device-scale-factor=2"]
},
{
"prefix": "scroll-unification-layout_ng_block_frag",
"bases": ["fast/forms/fieldset"],
"args": ["--enable-features=ScrollUnification",
"--enable-threaded-compositing",
"--enable-blink-features=LayoutNGBlockFragmentation"]
},
{
"prefix": "scroll-unification-overlay-scrollbar",
"bases": [],
"args": ["--enable-features=ScrollUnification",
"--enable-threaded-compositing",
"--enable-features=OverlayScrollbar"]
},
{
"prefix": "scroll-unification-percent-based-scrolling",
"bases": ["fast/scrolling/scrollbars"],
"args": ["--enable-features=ScrollUnification",
"--enable-features=PercentBasedScrolling",
"--enable-threaded-compositing",
"--enable-prefer-compositing-to-lcd-text",
"--disable-features=CompositorThreadedScrollbarScrolling"]
},
{
"prefix": "scroll-unification-prefer_compositing_to_lcd_text",
"bases": ["fast/scroll-behavior",
"scrollbars"],
"args": ["--enable-features=ScrollUnification",
"--enable-threaded-compositing",
"--enable-prefer-compositing-to-lcd-text"]
},
{
"prefix": "scroll-unification-synchronous_html_parser",
"bases": ["external/wpt/dom"],
"args": ["--enable-features=ScrollUnification",
"--enable-threaded-compositing",
"--enable-blink-features=ForceSynchronousHTMLParsing"]
},
{
"prefix": "scroll-unification-unified-autoplay",
"bases": ["external/wpt/feature-policy"],
"args": ["--enable-features=ScrollUnification",
"--enable-threaded-compositing",
"--autoplay-policy=document-user-activation-required"]
},
{
"prefix": "scroll-unification-wheel-event-regions",
"bases": ["fast/events/platform-wheelevent-paging-xy-in-scrolling-div.html",
"fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html",
"fast/events/wheel"],
"args": ["--enable-features=ScrollUnification",
"--enable-threaded-compositing",
"--disable-features=WheelEventRegions"]
},
{
"prefix": "disable-frequency-capping-for-overlay-popup-detection",
"bases": ["http/tests/subresource_filter/overlay_popup_ad"],
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This directory is dedicated for testing the "ScrollUnification" and "DisableNavigatorPluginsEmpty" feature.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This directory is dedicated for testing the "ScrollUnification" and "hidpi" feature.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This directory is dedicated for testing the "ScrollUnification" and "LayoutNGBlockFragmentation" feature.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This directory is dedicated for testing the "ScrollUnification" and "OverlayScrollbar" feature.
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
<head>
<script src="../../resources/js-test.js"></script>
<style>
body {
/* Hide the horizontal-scrollbar so that clicking right at the
bottom of the vertical scrollbar will trigger a scroll */
overflow-x: hidden;
}
#container {
/* The plugin is guaranteed not to be in the margin. */
margin-left: 10px;
}
</style>
</head>
<body>
<div id="container"></div>
<pre id="console"></pre>
</body>
<script>
description('This tests whether scrolling still works correctly when an '
+ 'overlay scrollbar is over a plugin. Clicking on the overlay scrollbar '
+ 'should cause it to activate and capture input.');

window.jsTestIsAsync = true;
var startLogging = false;
var eventHistory = [];

function runTest() {
internals.setScrollbarVisibilityInScrollableArea(document, true);

// Mouse down on the scrollbar thumb which is over the plugin.
eventSender.mouseMoveTo(window.innerWidth - 1, 50);
eventSender.mouseDown();
// Drag the thumb down but move off the thumb, the plugin shouldn't
// receive any events because there shouldn't be any mouse capture.
eventSender.mouseMoveTo(window.innerWidth - 20, window.innerHeight - 10);
// A mouse up will be received because when dragging off a
// scrollbar and releasing, it dispatches an event to the last
// element under the mouse.
eventSender.mouseUp();

// The scrollbar captures the input and the plugin should not receive
// events.
shouldBe('eventHistory.length', '0');
requestAnimationFrame(function() {
shouldBeTrue('window.scrollY > 0');
finishJSTest();
});
}

window.onload = function() {
if (!window.eventSender || !window.internals) {
finishJSTest();
return;
}

var plugin = document.createElement('object');
plugin.type = 'application/x-blink-test-plugin';
plugin.width = window.innerWidth * 2;
plugin.height = window.innerHeight * 2;
plugin.addEventListener('mousedown', function(e) {
startLogging = true;
eventHistory.push('plugin.mousedown');
});
plugin.addEventListener('mouseup', function(e) {
if (startLogging)
eventHistory.push('plugin.mouseup');
});
plugin.addEventListener('mousemove', function(e) {
if (startLogging)
eventHistory.push('plugin.mousemove');
});

var d = document.getElementById('container');
d.appendChild(plugin);

runTest();
}
</script>
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This directory is dedicated for testing the "ScrollUnification" and "PercentBasedScrolling" feature.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This directory is dedicated for testing the "ScrollUnification" and "PreferCompositingToLcdText" feature.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This directory is dedicated for testing the "ScrollUnification" and "ForceSynchronousHTMLParsing" feature.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This directory is dedicated for testing the "ScrollUnification" and "UnifiedAutoplay" feature.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This directory is dedicated for testing the "ScrollUnification" and "WheelEventRegions" feature.

0 comments on commit 3617a54

Please sign in to comment.