Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use helper macros to define base::Features in //net, part 1
This allows: - features to be defined with a consistent set of qualifiers, and for that set of qualifiers to be updated over time as appropriate. - better PRESUBMIT checks to ensure that base::Features are not defined in headers. - simplifies things for scripts trying to extract feature definitions out of C++ code. The primary CL was generated using a script that automatically rewrites base::Feature declarations and definitions to the macro form. Changes to any files with known incompatibilities with the macros (base::Features without static storage duration and base::Features declared as static class members) were then fully reverted; those changes will be manually handled in followups. This is a manual cleanup pass that fixed several instances missed by the original automation, since these use a non-standard export macro. Bug: 1364289 Change-Id: Id611ded07f8c7c817f88dfd5ec938e936c38d722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3931306 Reviewed-by: Lei Zhang <thestig@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Owners-Override: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1053885}
- Loading branch information