Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Categorical search] Revert persistent proto and re-enable ranking
This was causing a mysterious CFI-related crash which I'm having trouble finding the root cause of. This CL does a soft revert of the persistent proto class, because it won't git revert cleanly. At the same time, I've re-enabled some amount of ranking, in particular the result removal class. Also: - I've kept the API changes so if, in future, we figure out the cause then we don't need to change callsites. - I've updated the histogram and enums as appropriate. The kNoop value has never been reported in metrics [1] so this is a non-meaningful change to the histogram definition. [1] https://uma.googleplex.com/histograms/index.html?sid=0d816d3c94a657cd09aeffa0db9ed537 Bug: 1274853 Change-Id: If967bd5db47373cdaf1eb0fa3c117214131b43f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320779 Reviewed-by: Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/main@{#949965}
- Loading branch information