Skip to content

Commit

Permalink
[fuchsia] Moves gn configs to chromium.perf.
Browse files Browse the repository at this point in the history
New builder bots are being created in CI. This adds their GN configs.
-x64 will break with this change until the BuilderSpec is modified.
This is fine as the bot is expected to fail during this transition.

Should have no impact otherwise.

Change-Id: I50565f21523c4e7a48ed7f72c9e22d38dfe94ee2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3820550
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Rohan Pavone <rohpavone@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1033300}
  • Loading branch information
Rohan Pavone authored and Chromium LUCI CQ committed Aug 10, 2022
1 parent 788e028 commit 36edc7e
Show file tree
Hide file tree
Showing 3 changed files with 35 additions and 17 deletions.
3 changes: 2 additions & 1 deletion tools/mb/mb_config.pyl
Expand Up @@ -652,6 +652,8 @@
'chromecast-linux-builder-perf': 'cast_binary_size',
'chromeos-amd64-generic-lacros-builder-perf': 'chromeos_amd64-generic_lacros_official',
'chromeos-arm-generic-lacros-builder-perf': 'chromeos_arm-generic_lacros_official',
'fuchsia-builder-perf-arm64': 'official_goma_fuchsia_arm64_perf',
'fuchsia-builder-perf-x64': 'official_goma_fuchsia_x64_perf',
'linux-builder-perf': 'official_goma_linux_perf',
'linux-builder-perf-pgo': 'official_goma_linux_perf_pgo',
'linux-builder-perf-rel': 'official_goma_linux_perf',
Expand All @@ -673,7 +675,6 @@
'android_arm64-cfi-builder-perf-fyi': 'official_goma_minimal_symbols_android_thin_lto_opt_arm64',
'chromeos-kevin-builder-perf-fyi': 'chromeos_kevin_include_unwind_tables_official',
'fuchsia-builder-perf-fyi': 'official_goma_fuchsia_arm64_perf',
'fuchsia-builder-perf-x64': 'official_goma_fuchsia_x64_perf',
},

'chromium.reclient.fyi': {
Expand Down
16 changes: 0 additions & 16 deletions tools/mb/mb_config_expectations/chromium.perf.fyi.json
Expand Up @@ -56,21 +56,5 @@
"test_isolate_uses_emulator": false,
"use_goma": true
}
},
"fuchsia-builder-perf-x64": {
"gn_args": {
"ffmpeg_branding": "Chrome",
"fuchsia_additional_boot_images": [
"//third_party/fuchsia-sdk/images-internal/chromebook-x64-release/"
],
"is_chrome_branded": true,
"is_official_build": true,
"proprietary_codecs": true,
"symbol_level": 1,
"target_cpu": "x64",
"target_os": "fuchsia",
"test_isolate_uses_emulator": false,
"use_goma": true
}
}
}
33 changes: 33 additions & 0 deletions tools/mb/mb_config_expectations/chromium.perf.json
Expand Up @@ -124,6 +124,39 @@
"use_thin_lto": true
}
},
"fuchsia-builder-perf-arm64": {
"gn_args": {
"ffmpeg_branding": "Chrome",
"fuchsia_additional_boot_images": [
"//third_party/fuchsia-sdk/images-internal/astro-release/",
"//third_party/fuchsia-sdk/images-internal/sherlock-release/"
],
"is_chrome_branded": true,
"is_official_build": true,
"proprietary_codecs": true,
"symbol_level": 1,
"target_cpu": "arm64",
"target_os": "fuchsia",
"test_isolate_uses_emulator": false,
"use_goma": true
}
},
"fuchsia-builder-perf-x64": {
"gn_args": {
"ffmpeg_branding": "Chrome",
"fuchsia_additional_boot_images": [
"//third_party/fuchsia-sdk/images-internal/chromebook-x64-release/"
],
"is_chrome_branded": true,
"is_official_build": true,
"proprietary_codecs": true,
"symbol_level": 1,
"target_cpu": "x64",
"target_os": "fuchsia",
"test_isolate_uses_emulator": false,
"use_goma": true
}
},
"linux-builder-perf": {
"gn_args": {
"chrome_pgo_phase": 0,
Expand Down

0 comments on commit 36edc7e

Please sign in to comment.