Skip to content

Commit

Permalink
[P13n] Quick fix on sign-in promo metrics
Browse files Browse the repository at this point in the history
Fix the typo and incomplete change of sign-in promo metrics, as a
quick follow up for crrev/c/4104251.

(cherry picked from commit b7531ec)

Bug: 1382615
Change-Id: I8d881774a50fbee18578aff3e9938ed42fe4c25d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4117566
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1085698}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4117520
Cr-Commit-Position: refs/branch-heads/5481@{#137}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
  • Loading branch information
Tina Wang authored and Chromium LUCI CQ committed Jan 5, 2023
1 parent 5399e95 commit 3a02769
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
4 changes: 2 additions & 2 deletions tools/metrics/actions/actions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6772,7 +6772,7 @@ should be able to be added at any place in this file.
<owner>tinazwang@chromium.org</owner>
<owner>feed@chromium.org</owner>
<description>
The user has clickws the 'Cancel' button on the Feed sign-in promo UI.
The user has clicked the 'Cancel' button on the Feed sign-in promo UI.
</description>
</action>

Expand All @@ -6781,7 +6781,7 @@ should be able to be added at any place in this file.
<owner>tinazwang@chromium.org</owner>
<owner>feed@chromium.org</owner>
<description>
The user has clickws the 'Continue' button on the Feed sign-in promo UI.
The user has clicked the 'Continue' button on the Feed sign-in promo UI.
</description>
</action>

Expand Down
5 changes: 2 additions & 3 deletions tools/metrics/histograms/enums.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42351,10 +42351,9 @@ Called by update_permissions_policy_enum.py.-->
<int value="63"
label="User requested to refresh the Following feed using the
post-follow snackbar 'refresh' action."/>
<int value="64" label="User action caused a sign-in promo UI to be shown."/>
<int value="65"
<int value="64"
label="User tapped on the 'Continue' of the sign-in promo UI."/>
<int value="66" label="User tapped on the 'Cancel' of the sign-in promo UI."/>
<int value="65" label="User tapped on the 'Cancel' of the sign-in promo UI."/>
</enum>

<enum name="FeedUserCommandType">
Expand Down

0 comments on commit 3a02769

Please sign in to comment.