Skip to content

Commit

Permalink
flags: delete expired flag enable-palm-max-touch-major.
Browse files Browse the repository at this point in the history
Delete this long ago expired flag since it's enabled by default.

Bug: chromium:1207498
Test: browser_tests pass.
Change-Id: Ia2ca5fc1ee218d348423e61c7a5f37f27324429c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4258785
Reviewed-by: Amanda Deacon <amandadeacon@chromium.org>
Auto-Submit: Rob Schonberger <robsc@chromium.org>
Commit-Queue: Rob Schonberger <robsc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1106054}
  • Loading branch information
Rob Schonberger authored and Chromium LUCI CQ committed Feb 16, 2023
1 parent 59c38b0 commit 3afd7d3
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 21 deletions.
5 changes: 0 additions & 5 deletions chrome/browser/about_flags.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6593,11 +6593,6 @@ const FeatureEntry kFeatureEntries[] = {
flag_descriptions::kEnableOsFeedbackDescription, kOsCrOS,
FEATURE_VALUE_TYPE(ash::features::kOsFeedback)},

{"enable-palm-max-touch-major",
flag_descriptions::kEnablePalmOnMaxTouchMajorName,
flag_descriptions::kEnablePalmOnMaxTouchMajorDescription, kOsCrOS,
FEATURE_VALUE_TYPE(ui::kEnablePalmOnMaxTouchMajor)},

{"enable-heuristic-stylus-palm-rejection",
flag_descriptions::kEnableHeuristicStylusPalmRejectionName,
flag_descriptions::kEnableHeuristicStylusPalmRejectionDescription, kOsCrOS,
Expand Down
7 changes: 0 additions & 7 deletions chrome/browser/flag-metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2835,13 +2835,6 @@
"owners": [ "dibyapal@chromium.org", "desktop-pwas-team@google.com" ],
"expiry_milestone": 120
},
{
"name": "enable-palm-max-touch-major",
"owners": [ "robsc", "napper", "adlr" ],
// Added feature to possibly disable/enable this functionality, combined
// with neural net palm detection.
"expiry_milestone": 90
},
{
"name": "enable-palm-suppression",
"owners": [ "robsc", "napper", "hcutts", "chromeos-tango@google.com" ],
Expand Down
6 changes: 0 additions & 6 deletions chrome/browser/flag_descriptions.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5276,12 +5276,6 @@ const char kEnableNewShortcutMappingName[] = "Enable New Shortcut Mapping";
const char kEnableNewShortcutMappingDescription[] =
"Enables experimental new shortcut mapping";

const char kEnablePalmOnMaxTouchMajorName[] =
"Enable Palm when Touch is Maximum";
const char kEnablePalmOnMaxTouchMajorDescription[] =
"Experimental: Enable Palm detection when the touchscreen reports max "
"size. Not compatible with all devices.";

const char kEnablePalmSuppressionName[] =
"Enable Palm Suppression with Stylus.";
const char kEnablePalmSuppressionDescription[] =
Expand Down
3 changes: 0 additions & 3 deletions chrome/browser/flag_descriptions.h
Original file line number Diff line number Diff line change
Expand Up @@ -3018,9 +3018,6 @@ extern const char kEnableOsFeedbackDescription[];
extern const char kEnableNewShortcutMappingName[];
extern const char kEnableNewShortcutMappingDescription[];

extern const char kEnablePalmOnMaxTouchMajorName[];
extern const char kEnablePalmOnMaxTouchMajorDescription[];

extern const char kEnablePalmSuppressionName[];
extern const char kEnablePalmSuppressionDescription[];

Expand Down

0 comments on commit 3afd7d3

Please sign in to comment.