Scalable Status Area: Add a flag for show date in tray

Add a flag in chrome://flags to enable showing date in the tray button. (cherry picked from commit 8531248) Bug: 1161557 Change-Id: I02634d5b74a5823cc3f1dcb97154968f5e9318fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2720500 Reviewed-by: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#858021} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2739160 Cr-Commit-Position: refs/branch-heads/4430@{#162} Cr-Branched-From: e5ce7dc-refs/heads/master@{#857950}
chromium · Mar 5, 2021 · 3b27e8a · 3b27e8a
1 parent eb59357
commit 3b27e8a
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 2 deletions.
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
@@ -7197,6 +7197,10 @@ const FeatureEntry kFeatureEntries[] = {
     {"enable-scalable-status-area", flag_descriptions::kScalableStatusAreaName,
      flag_descriptions::kScalableStatusAreaDescription, kOsCrOS,
      FEATURE_VALUE_TYPE(ash::features::kScalableStatusArea)},
+
+    {"enable-show-date-in-tray", flag_descriptions::kShowDateInTrayName,
+     flag_descriptions::kShowDateInTrayDescription, kOsCrOS,
+     FEATURE_VALUE_TYPE(ash::features::kShowDateInTrayButton)},
 #endif
 
     {"autofill-address-save-prompt",

diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
@@ -2325,6 +2325,11 @@
     // Used for debugging and QA by the autofill team for the indefinite future.
     "expiry_milestone": -1
   },
+  {
+    "name": "enable-show-date-in-tray",
+    "owners": [ "leandre" ],
+    "expiry_milestone": 92
+  },
   {
     "name": "enable-sign-in-profile-creation",
     "owners": [ "jkrcal", "my-chrome-everywhere@google.com" ],

diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
@@ -4683,8 +4683,8 @@ const char kReleaseNotesNotificationAllChannelsDescription[] =
 
 const char kScalableStatusAreaName[] = "Enable Scalable Status Area";
 const char kScalableStatusAreaDescription[] =
-    "Showing important notification icons and date in status area when the "
-    "screen is sufficiently large.";
+    "Showing important notification icons in status area when the screen is "
+    "sufficiently large.";
 
 const char kScanningUIName[] = "Scanning UI";
 const char kScanningUIDescription[] =
@@ -4732,6 +4732,10 @@ const char kEnableBluetoothVerboseLogsForGooglersName[] =
 const char kEnableBluetoothVerboseLogsForGooglersDescription[] =
     "Enables Bluetooth verbose logs for Googlers in feedback reports.";
 
+const char kShowDateInTrayName[] = "Enable Show Date In Tray";
+const char kShowDateInTrayDescription[] =
+    "Showing date in status area when the screen is sufficiently large.";
+
 const char kShowTapsName[] = "Show taps";
 const char kShowTapsDescription[] =
     "Draws a circle at each touch point, which makes touch points more obvious "

diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
@@ -2770,6 +2770,9 @@ extern const char kShowBluetoothDebugLogToggleDescription[];
 extern const char kEnableBluetoothVerboseLogsForGooglersName[];
 extern const char kEnableBluetoothVerboseLogsForGooglersDescription[];
 
+extern const char kShowDateInTrayName[];
+extern const char kShowDateInTrayDescription[];
+
 extern const char kShowTapsName[];
 extern const char kShowTapsDescription[];
 

diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
@@ -46000,6 +46000,7 @@ from previous Chrome versions.
   <int value="403554154" label="SafetyCheckWeakPasswords:enabled"/>
   <int value="405329388"
       label="FramebustingNeedsSameOriginOrUserGesture:enabled"/>
+  <int value="407491045" label="ShowDateInTrayButton:enabled"/>
   <int value="408190863" label="OmniboxDisableInstantExtendedLimit:disabled"/>
   <int value="409566604" label="IntentPickerPWAPersistence:enabled"/>
   <int value="409622437" label="disable-buffer-bw-compression"/>
@@ -46758,6 +46759,7 @@ from previous Chrome versions.
   <int value="1108663108" label="disable-device-discovery-notifications"/>
   <int value="1109907837"
       label="PrefetchMainResourceNetworkIsolationKey:enabled"/>
+  <int value="1110683161" label="ShowDateInTrayButton:disabled"/>
   <int value="1111871757" label="ForceUnifiedConsentBump:enabled"/>
   <int value="1112051724" label="DetectingHeavyPages:enabled"/>
   <int value="1112817963" label="WebViewConnectionlessSafeBrowsing:enabled"/>