Skip to content

Commit

Permalink
ContentSettings: Revert CHECK back to DCHECK
Browse files Browse the repository at this point in the history
The CHECK added in https://crrev.com/c/4444634 is causing crashes that
we need to investigate. Revert back to DCHECK until then.

(cherry picked from commit 9ebd9d1)

Bug: 1466943
Change-Id: I22684ddb6b490c80ec2aab1748411b165b38363d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4748220
Auto-Submit: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Filipa Senra <fsenra@google.com>
Commit-Queue: Filipa Senra <fsenra@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1179088}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4790363
Auto-Submit: Daniel Yip <danielyip@google.com>
Commit-Queue: Daniel Yip <danielyip@google.com>
Owners-Override: Daniel Yip <danielyip@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5845@{#1509}
Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
  • Loading branch information
xchrdw authored and Chromium LUCI CQ committed Aug 17, 2023
1 parent 60bb8b5 commit 3dcd610
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ content_settings::PatternPair GetPatternsFromScopingType(
WebsiteSettingsInfo::ScopingType scoping_type,
const GURL& primary_url,
const GURL& secondary_url) {
CHECK(!primary_url.is_empty());
DCHECK(!primary_url.is_empty());
content_settings::PatternPair patterns;

switch (scoping_type) {
Expand Down

0 comments on commit 3dcd610

Please sign in to comment.